Add lint for ts files. Remove the majority of unused variables.

.eslintignore

@@ -3,4 +3,5 @@ node_modules
 **/node_modules/** 
 build/
 dist/
-volumes/
+volumes/
+.tslintrc.js

.tslintrc.js

@@ -0,0 +1,18 @@
+// This file has nothing to do with TSLint library
+// It's just ESLint config file for the typescript language
+
+module.exports = {
+    root: true,
+    env: {
+        browser: true,
+        node: true,
+        es6: true,
+        mocha: true
+    },
+    parser: '@typescript-eslint/parser',
+    plugins: ["@typescript-eslint"],
+    rules: {
+        // This is the only rule that should be enforced in typescript
+        '@typescript-eslint/no-unused-vars': 'error',
+    }
+}

contracts/test/unit_tests/proxy_test.ts

@@ -1,6 +1,6 @@
 const { expect } = require('chai');
 const { deployContract } = require('ethereum-waffle');
-const { wallet, wallet1, wallet2, deployTestContract, getCallRevertReason } = require('./common');
+const { wallet, wallet2, deployTestContract, getCallRevertReason } = require('./common');
 
 import { Contract, constants } from 'ethers';
 

contracts/test/unit_tests/specific_tokens_test.ts

@@ -4,11 +4,9 @@ import { ETHProxy } from 'zksync';
 import { Address, TokenAddress } from 'zksync/build/types';
 import { Deployer, readContractCode, readTestContracts } from '../../src.ts/deploy';
 
-const { simpleEncode } = require('ethereumjs-abi');
 const { expect } = require('chai');
 const { deployContract } = require('ethereum-waffle');
-const { wallet, exitWallet, deployTestContract, getCallRevertReason, IERC20_INTERFACE } = require('./common');
-import * as zksync from 'zksync';
+const { wallet, exitWallet, getCallRevertReason, IERC20_INTERFACE } = require('./common');
 
 async function onchainTokenBalanceOfContract(
     ethWallet: ethers.Wallet,

contracts/test/unit_tests/upgradeGatekeeper_test.ts

@@ -2,14 +2,14 @@ import { constants } from 'ethers';
 
 const { expect } = require('chai');
 const { deployContract } = require('ethereum-waffle');
-const { provider, wallet, wallet1, wallet2, deployTestContract, getCallRevertReason } = require('./common');
+const { provider, wallet, wallet2, deployTestContract, getCallRevertReason } = require('./common');
 
 const { performance } = require('perf_hooks');
 
 // some random constants for checking write and read from storage
 const bytes = [133, 174, 97, 255];
 
-import { Contract, ethers } from 'ethers';
+import { Contract } from 'ethers';
 
 const TX_OPTIONS = {
     gasLimit: 900000

contracts/test/unit_tests/zksync_test.ts

@@ -33,7 +33,7 @@ describe('zkSync signature verification unit tests', function () {
         const signature = await randomWallet.signMessage(
             zksync.utils.getChangePubkeyMessage(pubkeyHash, nonce, accountId)
         );
-        const { revertReason, result } = await getCallRevertReason(() =>
+        const { result } = await getCallRevertReason(() =>
             testContract.changePubkeySignatureCheck(
                 signature,
                 pubkeyHash.replace('sync:', '0x'),
@@ -410,6 +410,7 @@ describe('zkSync withdraw unit tests', function () {
         await zksyncContract.setBalanceToWithdraw(wallet.address, tokenId, withdrawAmount);
 
         const onchainBalBefore = await onchainBalance(wallet, tokenContract.address);
+        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         const { revertReason } = await getCallRevertReason(
             async () => await performWithdraw(wallet, tokenContract.address, tokenId, withdrawAmount.add(1))
         );

core/tests/ts-tests/tests/forced-exit.ts

@@ -1,7 +1,6 @@
 import { Tester } from './tester';
 import { expect } from 'chai';
-import { Wallet, types, utils } from 'zksync';
-import { BigNumber } from 'ethers';
+import { Wallet, types } from 'zksync';
 import { sleep } from 'zksync/build/utils';
 
 type TokenLike = types.TokenLike;

core/tests/ts-tests/tests/misc.ts

@@ -1,6 +1,6 @@
 import { Tester } from './tester';
 import { expect } from 'chai';
-import { Wallet, types, utils } from 'zksync';
+import { Wallet, types } from 'zksync';
 import { BigNumber } from 'ethers';
 
 type TokenLike = types.TokenLike;

core/tests/ts-tests/tests/priority-ops.ts

@@ -2,7 +2,6 @@ import { Tester } from './tester';
 import { expect } from 'chai';
 import { Wallet, types } from 'zksync';
 import { BigNumber } from 'ethers';
-import { sleep } from 'zksync/build/utils';
 
 type TokenLike = types.TokenLike;
 

core/tests/ts-tests/tests/transfer.ts

@@ -1,6 +1,6 @@
 import { Tester } from './tester';
 import { expect } from 'chai';
-import { Wallet, types, utils } from 'zksync';
+import { Wallet, types } from 'zksync';
 import { BigNumber } from 'ethers';
 
 type TokenLike = types.TokenLike;

core/tests/ts-tests/tests/withdraw.ts

@@ -1,6 +1,6 @@
 import { Tester } from './tester';
 import { expect } from 'chai';
-import { Wallet, types, utils } from 'zksync';
+import { Wallet, types } from 'zksync';
 import { BigNumber } from 'ethers';
 import { sleep } from 'zksync/build/utils';
 

infrastructure/fee-seller/tests.ts

@@ -1,5 +1,4 @@
-import { types } from 'zksync';
-import { BigNumber, BigNumberish, utils } from 'ethers';
+import { BigNumber, utils } from 'ethers';
 import { expect } from 'chai';
 import { isOperationFeeAcceptable, numberAsFractionInBIPs } from './utils';
 

infrastructure/fee-seller/utils.ts

@@ -104,7 +104,7 @@ export async function approveTokenIfNotApproved(signer: ethers.Signer, tokenAddr
     const approved = BigNumber.from(currentAllowance).gte(ERC20_APPROVE_TRESHOLD);
     if (!approved) {
         console.log(`Approving token ${tokenAddress}`);
-        const tx = await erc20contract.approve(contractAddress, MAX_ERC20_APPROVE_AMOUNT);
+        await erc20contract.approve(contractAddress, MAX_ERC20_APPROVE_AMOUNT);
     }
 }
 

infrastructure/sdk-test-vector-generator/src/types.ts

@@ -1,5 +1,3 @@
-import * as zksync from 'zksync';
-
 export interface TestVectorEntry {
     inputs: any;
     outputs: any;

infrastructure/zk/src/dummy-prover.ts

@@ -3,7 +3,6 @@ import * as utils from './utils';
 
 import * as server from './server';
 import * as contract from './contract';
-import * as db from './db/db';
 
 const VERIFIER_FILE = 'contracts/contracts/Verifier.sol';
 

infrastructure/zk/src/run/run.ts

@@ -146,7 +146,7 @@ command
 command
     .command('deploy-eip1271')
     .description('deploy test EIP-1271 "smart wallet"')
-    .action(async (cmd: Command) => {
+    .action(async () => {
         await deployEIP1271();
     });
 

package.json

@@ -35,9 +35,12 @@
     "zk": "yarn workspace zk",
     "lint:md": "markdownlint $(find . -name '*.md' -print -o -path '*/node_modules' -prune)",
     "lint:sol": "solhint contracts/{,dev-}contracts{,/**}/*.sol",
-    "lint:js": "eslint $(find . -name '*.js' | grep -v 'node_modules\\|build\\|dist')"
+    "lint:js": "eslint $(find . -name '*.js' | grep -v 'node_modules\\|build\\|dist\\|.tslintrc.js')",
+    "lint:ts": "eslint --ext ts --no-eslintrc -c .tslintrc.js $(find . -name '*.ts' | grep -v 'node_modules\\|build\\|dist')"
   },
   "devDependencies": {
+    "@typescript-eslint/eslint-plugin": "^4.10.0",
+    "@typescript-eslint/parser": "^4.10.0",
     "babel-eslint": "^10.1.0",
     "eslint": "^7.16.0",
     "eslint-config-alloy": "^3.8.2",

sdk/zksync.js/src/transport.ts

@@ -13,6 +13,7 @@ export abstract class AbstractJSONRPCTransport {
     subscriptionsSupported(): boolean {
         return false;
     }
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     async subscribe(subMethod: string, subParams, unsubMethod: string, cb: (data: any) => void): Promise<Subscription> {
         throw new Error('subscription are not supported for this transport');
     }

sdk/zksync.js/src/wallet.ts

@@ -11,7 +11,6 @@ import {
     PriorityOperationReceipt,
     TransactionReceipt,
     PubKeyHash,
-    TxEthSignature,
     ChangePubKey,
     EthSignerType,
     SignedTransaction,
@@ -22,12 +21,8 @@ import {
     IERC20_INTERFACE,
     isTokenETH,
     MAX_ERC20_APPROVE_AMOUNT,
-    getChangePubkeyMessage,
     SYNC_MAIN_CONTRACT_INTERFACE,
-    getSignedBytesFromMessage,
-    signMessagePersonalAPI,
     ERC20_DEPOSIT_GAS_LIMIT,
-    getEthSignatureType,
     serializeTransfer
 } from './utils';
 
@@ -632,7 +627,7 @@ export class Wallet {
                 try {
                     const gasEstimate = await mainZkSyncContract.estimateGas.depositERC20(...args).then(
                         (estimate) => estimate,
-                        (_err) => BigNumber.from('0')
+                        () => BigNumber.from('0')
                     );
                     txRequest.gasLimit = gasEstimate.gte(ERC20_DEPOSIT_GAS_LIMIT)
                         ? gasEstimate

sdk/zksync.js/tests/vectors.test.ts

@@ -190,10 +190,10 @@ describe(txVectors['description'], function () {
 
     it('ForcedExit signature', async function () {
         for (const item of txVectors.items) {
-            const { type: txType, ethPrivateKey, data: forcedExit, ethSignData } = item.inputs;
+            const { type: txType, ethPrivateKey, data: forcedExit } = item.inputs;
             const expected = item.outputs;
             const privateKey = parseHexWithPrefix(ethPrivateKey);
-            const { signer, ethMessageSigner } = await getSigner(privateKey);
+            const { signer } = await getSigner(privateKey);
 
             if (txType === 'ForcedExit') {
                 const signBytes = signer.forcedExitSignBytes(forcedExit);

sdk/zksync.js/tests/wallet.test.ts

@@ -1,10 +1,8 @@
-import { assert, expect } from 'chai';
-import { BigNumber, utils, ethers } from 'ethers';
+import { expect } from 'chai';
+import { BigNumber, ethers } from 'ethers';
 import { Wallet } from '../src/wallet';
 import { getTokens } from './helpers';
 
-import { TokenSet, parseHexWithPrefix } from '../src/utils';
-import { privateKeyFromSeed, signTransactionBytes } from '../src/crypto';
 import { Provider } from '../src/provider';
 
 describe('Wallet with mock provider', function () {