Merge pull request sparkle-project#554 from MaddTheSane/headers

Import the Foundation umbrella header in all the public headers.
kolpanic · Jun 4, 2015 · 2ed2f3d · 2ed2f3d
2 parents fbc7a7f + 3292c4e
commit 2ed2f3d
Show file tree

Hide file tree

Showing 15 changed files with 25 additions and 7 deletions.
diff --git a/Sparkle/SUAppcastItem.h b/Sparkle/SUAppcastItem.h
@@ -9,7 +9,8 @@
 #ifndef SUAPPCASTITEM_H
 #define SUAPPCASTITEM_H
 
-#include "SUExport.h"
+#import <Foundation/Foundation.h>
+#import "SUExport.h"
 
 SU_EXPORT @interface SUAppcastItem : NSObject
 @property (copy, readonly) NSString *title;

diff --git a/Sparkle/SUBinaryDeltaCommon.h b/Sparkle/SUBinaryDeltaCommon.h
@@ -9,6 +9,8 @@
 #ifndef SUBINARYDELTACOMMON_H
 #define SUBINARYDELTACOMMON_H
 
+#import <Foundation/Foundation.h>
+
 #include <fts.h>
 
 #define PERMISSION_FLAGS (S_IRWXU | S_IRWXG | S_IRWXO | S_ISUID | S_ISGID | S_ISVTX)
@@ -63,9 +65,6 @@ typedef NS_ENUM(uint16_t, SUBinaryDeltaMinorVersion)
 
 #define LATEST_DELTA_DIFF_MAJOR_VERSION SUBeigeMajorVersion
 
-@class NSString;
-@class NSData;
-
 extern int compareFiles(const FTSENT **a, const FTSENT **b);
 extern NSData *hashOfFileContents(FTSENT *ent);
 extern NSString *hashOfTreeWithVersion(NSString *path, uint16_t majorVersion);

diff --git a/Sparkle/SUConstants.h b/Sparkle/SUConstants.h
@@ -10,6 +10,8 @@
 #ifndef SUCONSTANTS_H
 #define SUCONSTANTS_H
 
+#import <Foundation/Foundation.h>
+
 // -----------------------------------------------------------------------------
 //	Misc:
 // -----------------------------------------------------------------------------

diff --git a/Sparkle/SUDSAVerifier.h b/Sparkle/SUDSAVerifier.h
@@ -15,6 +15,8 @@
 #ifndef SUDSAVERIFIER_H
 #define SUDSAVERIFIER_H
 
+#import <Foundation/Foundation.h>
+
 @interface SUDSAVerifier : NSObject
 
 + (BOOL)validatePath:(NSString *)path withEncodedDSASignature:(NSString *)encodedSignature withPublicDSAKey:(NSString *)pkeyString;

diff --git a/Sparkle/SUGuidedPackageInstaller.h b/Sparkle/SUGuidedPackageInstaller.h
@@ -22,11 +22,11 @@ A guided installation can be started by applications other than the application
 #ifndef SUGUIDEDPACKAGEINSTALLER_H
 #define SUGUIDEDPACKAGEINSTALLER_H
 
+#import <Foundation/Foundation.h>
 #import "Sparkle.h"
 #import "SUInstaller.h"
 
-@interface SUGuidedPackageInstaller : SUInstaller {
-}
+@interface SUGuidedPackageInstaller : SUInstaller
 
 /*! Perform the guided installation */
 + (void)performInstallationToPath:(NSString *)path fromPath:(NSString *)installerGuide host:(SUHost *)host versionComparator:(id<SUVersionComparison>)comparator completionHandler:(void (^)(NSError *))completionHandler;

diff --git a/Sparkle/SUHost.h b/Sparkle/SUHost.h
@@ -5,6 +5,7 @@
 //  Copyright 2008 Andy Matuschak. All rights reserved.
 //
 
+#import <Foundation/Foundation.h>
 #import "SUUpdater.h"
 #import "SUAppcast.h"
 #import "SUAppcastItem.h"

diff --git a/Sparkle/SUPackageInstaller.h b/Sparkle/SUPackageInstaller.h
@@ -9,6 +9,8 @@
 #ifndef SUPACKAGEINSTALLER_H
 #define SUPACKAGEINSTALLER_H
 
+#import <Foundation/Foundation.h>
+
 #import "SUUpdater.h"
 
 #import "SUAppcast.h"

diff --git a/Sparkle/SUPlainInstaller.h b/Sparkle/SUPlainInstaller.h
@@ -9,6 +9,8 @@
 #ifndef SUPLAININSTALLER_H
 #define SUPLAININSTALLER_H
 
+#import <Foundation/Foundation.h>
+
 #import "SUUpdater.h"
 
 #import "SUAppcast.h"

diff --git a/Sparkle/SUPlainInstallerInternals.h b/Sparkle/SUPlainInstallerInternals.h
@@ -9,6 +9,8 @@
 #ifndef SUPLAININSTALLERINTERNALS_H
 #define SUPLAININSTALLERINTERNALS_H
 
+#import <Foundation/Foundation.h>
+
 #import "SUPlainInstaller.h"
 
 @interface SUPlainInstaller (Internals)

diff --git a/Sparkle/SUStandardVersionComparator.h b/Sparkle/SUStandardVersionComparator.h
@@ -9,6 +9,7 @@
 #ifndef SUSTANDARDVERSIONCOMPARATOR_H
 #define SUSTANDARDVERSIONCOMPARATOR_H
 
+#import <Foundation/Foundation.h>
 #import "SUExport.h"
 #import "SUVersionComparisonProtocol.h"
 

diff --git a/Sparkle/SUSystemProfiler.h b/Sparkle/SUSystemProfiler.h
@@ -9,7 +9,7 @@
 #ifndef SUSYSTEMPROFILER_H
 #define SUSYSTEMPROFILER_H
 
-#import <Cocoa/Cocoa.h>
+#import <Foundation/Foundation.h>
 
 @class SUHost;
 @interface SUSystemProfiler : NSObject

diff --git a/Sparkle/SUSystemProfiler.m b/Sparkle/SUSystemProfiler.m
@@ -7,6 +7,7 @@
 //  Adapted from Sparkle+, by Tom Harrington.
 //
 
+#import <Cocoa/Cocoa.h>
 #import "SUSystemProfiler.h"
 
 #import "SUHost.h"

diff --git a/Sparkle/SUUnarchiver.h b/Sparkle/SUUnarchiver.h
@@ -9,6 +9,8 @@
 #ifndef SUUNARCHIVER_H
 #define SUUNARCHIVER_H
 
+#import <Foundation/Foundation.h>
+
 @class SUHost;
 @protocol SUUnarchiverDelegate;
 

diff --git a/Sparkle/SUUpdater.h b/Sparkle/SUUpdater.h
@@ -9,6 +9,7 @@
 #ifndef SUUPDATER_H
 #define SUUPDATER_H
 
+#import <Foundation/Foundation.h>
 #import "SUExport.h"
 #import "SUVersionComparisonProtocol.h"
 #import "SUVersionDisplayProtocol.h"

diff --git a/Sparkle/Sparkle.h b/Sparkle/Sparkle.h
@@ -9,6 +9,8 @@
 #ifndef SPARKLE_H
 #define SPARKLE_H
 
+#import <Cocoa/Cocoa.h>
+
 // This list should include the shared headers. It doesn't matter if some of them aren't shared (unless
 // there are name-space collisions) so we can list all of them to start with: