-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a ReleaseLink validating webhook #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbieren
commented
Apr 19, 2022
johnbieren
force-pushed
the
release_link_webhook
branch
5 times, most recently
from
April 19, 2022 01:46
acec660
to
8dc3816
Compare
redhat-appstudio/application-service#25 is a similar PR to help review |
johnbieren
force-pushed
the
release_link_webhook
branch
3 times, most recently
from
April 20, 2022 19:38
1bbbb01
to
971f940
Compare
johnbieren
changed the title
WIP: Add a ReleaseLink validating webhook
Add a ReleaseLink validating webhook
Apr 20, 2022
johnbieren
force-pushed
the
release_link_webhook
branch
3 times, most recently
from
April 21, 2022 00:19
61450d1
to
6980d14
Compare
davidmogar
reviewed
Apr 21, 2022
johnbieren
force-pushed
the
release_link_webhook
branch
4 times, most recently
from
April 22, 2022 16:54
d878051
to
83fda06
Compare
davidmogar
reviewed
Apr 22, 2022
johnbieren
force-pushed
the
release_link_webhook
branch
2 times, most recently
from
April 22, 2022 20:05
704de74
to
f58350b
Compare
davidmogar
reviewed
Apr 22, 2022
johnbieren
force-pushed
the
release_link_webhook
branch
from
April 22, 2022 20:10
f58350b
to
90c1790
Compare
davidmogar
approved these changes
Apr 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to remove the defaulting
in this webhook, but it can be done in a future PR.
Add a webhook that ensures that no ReleaseLinks are created or updated to a state with its target equal to its namespace Signed-off-by: Johnny Bieren <[email protected]>
Signed-off-by: Johnny Bieren <[email protected]>
johnbieren
force-pushed
the
release_link_webhook
branch
from
April 25, 2022 12:12
90c1790
to
537ecc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a webhook that ensures that no ReleaseLinks are created
or updated to a state with its target the empty string
or the target equal to its namespace
Signed-off-by: Johnny Bieren [email protected]