config rewrite discard dynamically set a configuration which value is…

… empty (OpenAtomFoundation#455)
konkona · Dec 28, 2018 · 97a7526 · 97a7526
1 parent aa9a6a4
commit 97a7526
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/src/pika_admin.cc b/src/pika_admin.cc
@@ -95,6 +95,7 @@ void SlaveofCmd::Do() {
 
     if (is_noone_) {
       res_.SetRes(CmdRes::kOk);
+      g_pika_conf->SetSlaveof(std::string());
       return;
     }
 

diff --git a/src/pika_conf.cc b/src/pika_conf.cc
@@ -355,11 +355,19 @@ int PikaConf::ConfigRewrite() {
   }
 
   if (!diff_commands_.empty()) {
-    slash::BaseConf::Rep::ConfItem item(slash::BaseConf::Rep::kComment, "# Generated by CONFIG REWRITE\n");
-    PushConfItem(item);
+    std::vector<slash::BaseConf::Rep::ConfItem> filtered_items;
     for (const auto& diff_command : diff_commands_) {
-      slash::BaseConf::Rep::ConfItem item(slash::BaseConf::Rep::kConf, diff_command.first, diff_command.second);
-      PushConfItem(item);
+      if (!diff_command.second.empty()) {
+        slash::BaseConf::Rep::ConfItem item(slash::BaseConf::Rep::kConf, diff_command.first, diff_command.second);
+        filtered_items.push_back(item);
+      }
+    }
+    if (!filtered_items.empty()) {
+      slash::BaseConf::Rep::ConfItem comment_item(slash::BaseConf::Rep::kComment, "# Generated by CONFIG REWRITE\n");
+      PushConfItem(comment_item);
+      for (const auto& item : filtered_items) {
+        PushConfItem(item);
+      }
     }
     RWLock l(&rwlock_, true);
     diff_commands_.clear();
-Original file line number
+Diff line change
@@ Expand Up / @@ -95,6 +95,7 @@ void SlaveofCmd::Do() { @@
         if (is_noone_) {
           res_.SetRes(CmdRes::kOk);
+          g_pika_conf->SetSlaveof(std::string());
           return;
         }
@@ Expand Down @@