Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporter refactor #133

Merged
merged 10 commits into from
Mar 26, 2015
Merged

Exporter refactor #133

merged 10 commits into from
Mar 26, 2015

Conversation

chelm
Copy link
Contributor

@chelm chelm commented Mar 25, 2015

This is the first pass a bit of a cleaned up exporter. Its still a bit of mess i think and the logic needs to be rewritten, but at least not we have the minimum amount of code being duplicated across methods.

Also added the ability to support projections for shapefiles only, if a wkid is passed in.

@ungoldman
Copy link
Contributor

Definitely big enough that it's hard to follow what's being refactored. Are there any breaking changes?

@ungoldman
Copy link
Contributor

or just things that were exposed on the koop object that are no longer there or anything like that

@chelm
Copy link
Contributor Author

chelm commented Mar 25, 2015

@ngoldman yeah its huge, no breaking changes just a reworking of shared code. This is a work in progress for sure, but need to get the projection code out for our release next week.

@ungoldman
Copy link
Contributor

👍 ok just trying to keep up so I can contribute once I'm out of this never-ending multi-day multi-state meeting

@chelm
Copy link
Contributor Author

chelm commented Mar 25, 2015

grrr failing test!

@jwieringa
Copy link

If the failing test is related to a gdal dependency, take a look at how @scooterw is configuring Travis to install GDAL https://github.com/scooterw/ffi-ogr/blob/master/before_install.sh

Something like this in the travis config might do the trick?

before_install:
  - sudo apt-key adv --recv-keys --keyserver keyserver.ubuntu.com 16126D3A3E5C1192
  - sudo apt-get install python-software-properties -y
  - sudo add-apt-repository ppa:ubuntugis/ppa -y
  - sudo apt-get update -qq
  - sudo apt-get install libgdal-dev

@ungoldman
Copy link
Contributor

@jwieringa++

@ungoldman
Copy link
Contributor

calls to ogr2ogr/gdal is probably something we can eventually bust out of core and test independently too

@chelm
Copy link
Contributor Author

chelm commented Mar 26, 2015

Thanks @jwieringa
and yeah @ngoldman totally the next move. Just like tiles, exporting become a plugin. The move today was very much towards that but there are still some dependencies i need to re-think before the trigger it pulled.

im gonna merge this...

chelm added a commit that referenced this pull request Mar 26, 2015
@chelm chelm merged commit 36dea37 into master Mar 26, 2015
@chelm chelm deleted the exporter-refactor branch March 26, 2015 02:22
rgwozdz pushed a commit that referenced this pull request Oct 7, 2022
rgwozdz added a commit that referenced this pull request Oct 7, 2022
* Only cache if ttl is set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants