-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exporter refactor #133
Exporter refactor #133
Conversation
Definitely big enough that it's hard to follow what's being refactored. Are there any breaking changes? |
or just things that were exposed on the koop object that are no longer there or anything like that |
@ngoldman yeah its huge, no breaking changes just a reworking of shared code. This is a work in progress for sure, but need to get the projection code out for our release next week. |
👍 ok just trying to keep up so I can contribute once I'm out of this never-ending multi-day multi-state meeting |
grrr failing test! |
If the failing test is related to a gdal dependency, take a look at how @scooterw is configuring Travis to install GDAL https://github.com/scooterw/ffi-ogr/blob/master/before_install.sh Something like this in the travis config might do the trick?
|
calls to ogr2ogr/gdal is probably something we can eventually bust out of core and test independently too |
Thanks @jwieringa im gonna merge this... |
This is the first pass a bit of a cleaned up exporter. Its still a bit of mess i think and the logic needs to be rewritten, but at least not we have the minimum amount of code being duplicated across methods.
Also added the ability to support projections for shapefiles only, if a wkid is passed in.