Add OSGi support #169
Add OSGi support #169
Conversation
- generate OSGi Manifest Headers - optional OSGi dependencies - IkonHandler resolution with OSGi DS instead of SPI
|
Solves #35 |
| protected boolean registerHandler(IkonHandler handler, Set<IkonHandler> handlers, Set<IkonHandler> customHandlers) { | ||
| // check whether handler for this font is already loaded via classpath | ||
| if (isLoadedViaClasspath(handler, handlers)) { | ||
| protected final Set<IkonHandler> handlers = new CopyOnWriteArraySet<>(); |
There was a problem hiding this comment.
I believe there was a reason to keep this class stateless but I can't recall now.
There was a problem hiding this comment.
The current implentations are already stateful.
core/ikonli-core/src/main/java/org/kordamp/ikonli/AbstractIkonResolver.java
Outdated
Show resolved
Hide resolved
core/ikonli-swing/src/main/java/org/kordamp/ikonli/swing/FontIcon.java
Outdated
Show resolved
Hide resolved
core/ikonli-swing/src/main/java/org/kordamp/ikonli/swing/SwingFontLoader.java
Show resolved
Hide resolved
icon-packs/ikonli-antdesignicons-pack/src/main/java/module-info.java
Outdated
Show resolved
Hide resolved
|
Thank you for submitting this PR 😄 |
|
I apologize for the whitespace issues - I didn't realize the 4-space requirement. Regarding the import ordering: yes, this was caused by Eclipse's default formatting |
|
I fixed your findings but I don't understand what is going on. The build is still failing:
But they have license headers. |
|
The problem seems to be the copyright year is still set to |
Add OSGi support