QUIC: Don't complete writes on abort (dotnet#43630)

kordevelopers · Sep 2, 2022 · e3509ec · e3509ec
1 parent d34e667
commit e3509ec
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/Servers/Kestrel/Kestrel.slnf b/src/Servers/Kestrel/Kestrel.slnf
@@ -26,6 +26,7 @@
       "src\\Middleware\\Diagnostics\\src\\Microsoft.AspNetCore.Diagnostics.csproj",
       "src\\Middleware\\HostFiltering\\src\\Microsoft.AspNetCore.HostFiltering.csproj",
       "src\\Middleware\\HttpOverrides\\src\\Microsoft.AspNetCore.HttpOverrides.csproj",
+      "src\\Middleware\\StaticFiles\\src\\Microsoft.AspNetCore.StaticFiles.csproj",
       "src\\ObjectPool\\src\\Microsoft.Extensions.ObjectPool.csproj",
       "src\\Security\\Authentication\\Core\\src\\Microsoft.AspNetCore.Authentication.csproj",
       "src\\Security\\Authorization\\Core\\src\\Microsoft.AspNetCore.Authorization.csproj",

diff --git a/src/Servers/Kestrel/Transport.Quic/src/Internal/QuicStreamContext.cs b/src/Servers/Kestrel/Transport.Quic/src/Internal/QuicStreamContext.cs
@@ -465,7 +465,7 @@ private async ValueTask DoSendAsync()
         }
         finally
         {
-            ShutdownWrite(_shutdownWriteReason ?? _shutdownReason ?? shutdownReason);
+            ShutdownWrite(shutdownReason);
 
             await waitForWritesClosedTask;
 
@@ -525,10 +525,14 @@ private void ShutdownWrite(Exception? shutdownReason)
         {
             lock (_shutdownLock)
             {
-                _shutdownReason = shutdownReason ?? SendGracefullyCompletedException;
+                _shutdownReason = _shutdownWriteReason ?? _shutdownReason ?? shutdownReason ?? SendGracefullyCompletedException;
                 QuicLog.StreamShutdownWrite(_log, this, _shutdownReason.Message);
 
-                _stream.CompleteWrites();
+                // Only complete writes for a graceful shutdown.
+                if (_shutdownReason == SendGracefullyCompletedException)
+                {
+                    _stream.CompleteWrites();
+                }
             }
         }
         catch (Exception ex)