Fix embedding initialization issue asyml#47 (asyml#48)

Fix embedding initialization issue asyml#47
kormilitzin · Jun 18, 2019 · 05a5f61 · 05a5f61
2 parents f7c79ad + 371b5ce
commit 05a5f61
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/texar/modules/embedders/embedder_utils.py b/texar/modules/embedders/embedder_utils.py
@@ -148,9 +148,9 @@ def get_embedding(num_embeds: Optional[int] = None,
         embedding = torch.empty(size=[num_embeds] + dim)
         # initializer should be set by layers.get_initializer
         if initializer:
-            embedding = initializer(embedding)
+            initializer(embedding)
         else:
-            embedding = torch.nn.init.xavier_uniform_(embedding)
+            torch.nn.init.xavier_uniform_(embedding)
     else:
         if torch.is_tensor(init_value):
             embedding = init_value  # Do not copy the tensor.