(PUP-838) Process uses LookupPrivilegeValueW

 - Switch from LookupPrivilegeValueA to LookupPrivilegeValueW
 - In reality, this doesn't absolutely need to be done, but for the sake
   of consistency with other API calls, we use W suffixed functions
 - Add 2 tests that confirm that our usage of the Win32 API call is
   correct

lib/puppet/util/windows/process.rb

@@ -3,6 +3,7 @@
 require 'ffi'
 
 module Puppet::Util::Windows::Process
+  extend Puppet::Util::Windows::String
   extend FFI::Library
 
   WAIT_TIMEOUT = 0x102
@@ -57,9 +58,9 @@ def open_process_token(handle, desired_access)
 
   def lookup_privilege_value(name, system_name = '')
     luid = FFI::MemoryPointer.new(LUID.size)
-    result = LookupPrivilegeValueA(
-      system_name,
-      name.to_s,
+    result = LookupPrivilegeValueW(
+      wide_string(system_name),
+      wide_string(name.to_s),
       luid
       )
 
@@ -221,8 +222,8 @@ class LUID < FFI::Struct
   #   _Out_     PLUID lpLuid
   # );
   ffi_lib 'advapi32'
-  attach_function_private :LookupPrivilegeValueA,
-    [:lpcstr, :lpcstr, :pointer], :win32_bool
+  attach_function_private :LookupPrivilegeValueW,
+    [:lpcwstr, :lpcwstr, :pointer], :win32_bool
 
   # http://msdn.microsoft.com/en-us/library/windows/desktop/aa379626(v=vs.85).aspx
   TOKEN_INFORMATION_CLASS = enum(

spec/integration/util/windows/process_spec.rb

@@ -18,5 +18,16 @@
       Puppet::Util::Windows::User.should be_admin
       Puppet::Util::Windows::Process.process_privilege_symlink?.should be_false
     end
+
+    it "should be able to lookup a standard Windows process privilege" do
+      luid = Puppet::Util::Windows::Process.lookup_privilege_value('SeShutdownPrivilege')
+      luid.should_not be_nil
+      luid.should be_instance_of(Puppet::Util::Windows::Process::LUID)
+    end
+
+    it "should raise an error for an unknown privilege name" do
+      fail_msg = /LookupPrivilegeValue\(, foo, .*\):  A specified privilege does not exist/
+      expect { Puppet::Util::Windows::Process.lookup_privilege_value('foo') }.to raise_error(Puppet::Util::Windows::Error, fail_msg)
+    end
   end
 end