Added setter to ValueType. (ardalis#46)

* Added setter to ValueType. * Set ValueType if value not null. * Value.GetType removed from private Result(ResultStatus status). * Result to be partial. * Partial removed from Result * ClearValueType and ValueType private set. Co-authored-by: Steve Smith <[email protected]>
kriscirx · Sep 4, 2020 · f500b6a · f500b6a
1 parent ac5e391
commit f500b6a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/src/Ardalis.Result/Ardalis.Result.csproj b/src/Ardalis.Result/Ardalis.Result.csproj
@@ -12,8 +12,8 @@
     <Summary>A simple package to implement the Result pattern for returning from services.</Summary>
     <RepositoryUrl>https://github.com/ardalis/result</RepositoryUrl>
     <PackageTags>result pattern web api aspnetcore mvc</PackageTags>
-    <PackageReleaseNotes>Updating icon to remove deprecated PackageIconUrl</PackageReleaseNotes>
-    <Version>3.0.1</Version>
+    <PackageReleaseNotes>Added setter to ValueType</PackageReleaseNotes>
+    <Version>3.0.2</Version>
     <AssemblyName>Ardalis.Result</AssemblyName>
     <PackageIcon>icon.png</PackageIcon>
     <PublishRepositoryUrl>true</PublishRepositoryUrl>

diff --git a/src/Ardalis.Result/Result.cs b/src/Ardalis.Result/Result.cs
@@ -8,6 +8,11 @@ public class Result<T> : IResult
         public Result(T value)
         {
             Value = value;
+            if (Value != null)
+            {
+                ValueType = Value.GetType();
+            }
+
         }
         private Result(ResultStatus status)
         {
@@ -18,11 +23,14 @@ private Result(ResultStatus status)
         public static implicit operator Result<T>(T value) => Success(value);
 
         public T Value { get; }
-        public Type ValueType => Value.GetType();
+
+        public Type ValueType { get; private set; }
         public ResultStatus Status { get; } = ResultStatus.Ok;
         public IEnumerable<string> Errors { get; private set; } = new List<string>();
         public List<ValidationError> ValidationErrors { get; private set; } = new List<ValidationError>();
 
+        public void ClearValueType() => ValueType = null;
+
         public object GetValue()
         {
             return this.Value;
@@ -51,6 +59,6 @@ public static Result<T> NotFound()
         public static Result<T> Forbidden()
         {
             return new Result<T>(ResultStatus.Forbidden);
-        }
+        }        
     }
 }