Skip to content

Commit

Permalink
Merge heads.
Browse files Browse the repository at this point in the history
  • Loading branch information
warsaw committed Jan 11, 2016
2 parents 0633cb7 + 3d220cc commit 305e355
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
3 changes: 0 additions & 3 deletions Misc/NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ Release date: tba
Core and Builtins
-----------------

- Issue #22995: [UPDATE] Comment out the one of the pickleability tests in
_PyObject_GetState() due to regressions observed in Cython-based projects.

- Issue #25961: Disallowed null characters in the type name.

- Issue #25973: Fix segfault when an invalid nonlocal statement binds a name
Expand Down
9 changes: 0 additions & 9 deletions Objects/typeobject.c
Original file line number Diff line number Diff line change
Expand Up @@ -3872,14 +3872,6 @@ _PyObject_GetState(PyObject *obj, int required)
}

assert(slotnames == Py_None || PyList_Check(slotnames));
#if 0
/* 2016-01-11 barry - This clause breaks at least three packages which
rely on Cython: kivy, pysam, and s3ql. Cython may be doing
something funny under the hood, but as this is clearly a regression
and the rationale for this prohibition is suspect, I am commenting
this out. Perhaps it should just be removed. See issue #22995 for
details.
*/
if (required) {
Py_ssize_t basicsize = PyBaseObject_Type.tp_basicsize;
if (obj->ob_type->tp_dictoffset)
Expand All @@ -3897,7 +3889,6 @@ _PyObject_GetState(PyObject *obj, int required)
return NULL;
}
}
#endif

if (slotnames != Py_None && Py_SIZE(slotnames) > 0) {
PyObject *slots;
Expand Down

0 comments on commit 305e355

Please sign in to comment.