Skip to content

Commit

Permalink
Typos and FIXMEs
Browse files Browse the repository at this point in the history
  • Loading branch information
Solomon Hykes authored and vieux committed Oct 25, 2013
1 parent 4576d0f commit f7a2f0b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions gograph/gograph.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,11 @@ func (db *Database) Set(fullPath, id string) (*Entity, error) {
return nil, err
}
defer conn.Close()
// FIXME: is rollback implicit when closing the connection?
rollback := func() {
conn.Exec("ROLLBACK")
}
// FIXME: use exclusive transactions to avoid race conditions
if _, err := conn.Exec("BEGIN"); err != nil {
return nil, err
}
Expand Down
2 changes: 1 addition & 1 deletion gograph/gograph_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ func destroyTestDb(db *Database) {
func TestNewDatabase(t *testing.T) {
db := newTestDb(t)
if db == nil {
t.Fatal("Datbase should not be nil")
t.Fatal("Database should not be nil")
}
defer destroyTestDb(db)
}
Expand Down

0 comments on commit f7a2f0b

Please sign in to comment.