[pigeon] removed warnings from Dart generated code (flutter#123)

krmao · Mar 24, 2020 · c1a2bf8 · c1a2bf8
1 parent d410ceb
commit c1a2bf8
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 2 deletions.
diff --git a/packages/pigeon/CHANGELOG.md b/packages/pigeon/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.1.0-experimental.7
+
+* Suppressed or got rid of warnings in generated Dart code.
+
 ## 0.1.0-experimental.6
 
 * Added support for void return types.

diff --git a/packages/pigeon/lib/dart_generator.dart b/packages/pigeon/lib/dart_generator.dart
@@ -92,6 +92,8 @@ void generateDart(Root root, StringSink sink) {
   final Indent indent = Indent(sink);
   indent.writeln('// $generatedCodeWarning');
   indent.writeln('// $seeAlsoWarning');
+  indent.writeln('// ignore_for_file: public_member_api_docs');
+  indent.writeln('import \'dart:async\';');
   indent.writeln('import \'package:flutter/services.dart\';');
   indent.writeln('');
 

diff --git a/packages/pigeon/lib/generator_tools.dart b/packages/pigeon/lib/generator_tools.dart
@@ -8,7 +8,7 @@ import 'dart:mirrors';
 import 'ast.dart';
 
 /// The current version of pigeon.
-const String pigeonVersion = '0.1.0-experimental.6';
+const String pigeonVersion = '0.1.0-experimental.7';
 
 /// Read all the content from [stdin] to a String.
 String readStdin() {

diff --git a/packages/pigeon/pubspec.yaml b/packages/pigeon/pubspec.yaml
@@ -1,5 +1,5 @@
 name: pigeon
-version: 0.1.0-experimental.6
+version: 0.1.0-experimental.7
 description: Code generator tool to make communication between Flutter and the host platform type-safe and easier.
 homepage: https://github.com/flutter/packages/tree/master/packages/pigeon
 dependencies:

diff --git a/packages/pigeon/run_tests.sh b/packages/pigeon/run_tests.sh
@@ -49,10 +49,14 @@ test_pigeon_android() {
 }
 
 pub run test test/
+test_pigeon_android ./pigeons/voidflutter.dart
+test_pigeon_android ./pigeons/voidhost.dart
 test_pigeon_android ./pigeons/host2flutter.dart
 test_pigeon_android ./pigeons/message.dart
 test_pigeon_ios ./pigeons/message.dart
 test_pigeon_ios ./pigeons/host2flutter.dart
+test_pigeon_ios ./pigeons/voidhost.dart
+test_pigeon_ios ./pigeons/voidflutter.dart
 
 pub run pigeon \
   --input pigeons/message.dart \