Skip to content

Commit

Permalink
scsi: pm8001: Fix misindentation
Browse files Browse the repository at this point in the history
kernel robot reported a misindentation of a goto.

Fix it.

At the same time, use a temporary for a repeated entry in the same block to
reduce visual noise.

Link: https://lore.kernel.org/r/9542a8be9954c1dca744f93f53bb1af6dd1436e8.1606192458.git.joe@perches.com
Reported-by: kernel test robot <[email protected]>
Acked-by: Jack Wang <[email protected]>
Signed-off-by: Joe Perches <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
  • Loading branch information
JoePerches authored and martinkpetersen committed Dec 1, 2020
1 parent 2ce6e20 commit 9aed578
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions drivers/scsi/pm8001/pm8001_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -386,17 +386,17 @@ static int pm8001_alloc(struct pm8001_hba_info *pm8001_ha,
pm8001_ha->memoryMap.region[FORENSIC_MEM].element_size = 0x10000;
pm8001_ha->memoryMap.region[FORENSIC_MEM].alignment = 0x10000;
for (i = 0; i < pm8001_ha->max_memcnt; i++) {
struct mpi_mem *region = &pm8001_ha->memoryMap.region[i];

if (pm8001_mem_alloc(pm8001_ha->pdev,
&pm8001_ha->memoryMap.region[i].virt_ptr,
&pm8001_ha->memoryMap.region[i].phys_addr,
&pm8001_ha->memoryMap.region[i].phys_addr_hi,
&pm8001_ha->memoryMap.region[i].phys_addr_lo,
pm8001_ha->memoryMap.region[i].total_len,
pm8001_ha->memoryMap.region[i].alignment) != 0) {
pm8001_dbg(pm8001_ha, FAIL,
"Mem%d alloc failed\n",
i);
goto err_out;
&region->virt_ptr,
&region->phys_addr,
&region->phys_addr_hi,
&region->phys_addr_lo,
region->total_len,
region->alignment) != 0) {
pm8001_dbg(pm8001_ha, FAIL, "Mem%d alloc failed\n", i);
goto err_out;
}
}

Expand Down

0 comments on commit 9aed578

Please sign in to comment.