list become optional

krrrr38 · Apr 29, 2016 · efcdeb4 · efcdeb4
1 parent 4278c9c
commit efcdeb4
Show file tree

Hide file tree

Showing 9 changed files with 12 additions and 6 deletions.
diff --git a/plugins/jabot-job-handler/README.md b/plugins/jabot-job-handler/README.md
@@ -3,7 +3,7 @@
 Schedule message management handler.
 
 ```sh
-list jobs
+list jobs # or `jobs`
 add job "<cron syntax>" <message>
 delete job <index:\\d+>
 ```

diff --git a/plugins/jabot-job-handler/src/main/java/com/krrrr38/jabot/plugin/handler/JobHandler.java b/plugins/jabot-job-handler/src/main/java/com/krrrr38/jabot/plugin/handler/JobHandler.java
@@ -32,7 +32,7 @@ List<Rule> buildRules(Map<String, String> options) {
 
     private final Rule JOB_LIST =
             new Rule(
-                    Pattern.compile("\\Alist jobs\\z", Pattern.CASE_INSENSITIVE),
+                    Pattern.compile("\\A(list )?jobs\\z", Pattern.CASE_INSENSITIVE),
                     HANDLER_NAME,
                     "Show registered jobs",
                     "list jobs",

diff --git a/plugins/jabot-job-handler/src/test/java/com/krrrr38/jabot/plugin/handler/JobHandlerTest.java b/plugins/jabot-job-handler/src/test/java/com/krrrr38/jabot/plugin/handler/JobHandlerTest.java
@@ -39,6 +39,8 @@ public void testReceive() throws Exception {
 
         assertThat(handler.receive(null, "list jobs"), is(Optional.empty()));
         assertThat(queue.peekLast().getMessage(), containsString("No registered jobs"));
+        assertThat(handler.receive(null, "jobs"), is(Optional.empty()));
+        assertThat(queue.peekLast().getMessage(), containsString("No registered jobs"));
 
         assertThat(handler.receive(null, "add job \"* * a * *\" invalid cron syntax"), is(Optional.empty()));
         assertThat(queue.peekLast().getMessage(), containsString("Failed to register job"));

diff --git a/plugins/jabot-replace-handler/README.md b/plugins/jabot-replace-handler/README.md
@@ -3,7 +3,7 @@
 Replace given message with registered patterns for other handlers.
 
 ```sh
-list patterns
+list patterns # or `patterns`
 replace <from> with <to>
 delete pattern <from>
 delete all patterns

diff --git a/.../jabot-replace-handler/src/main/java/com/krrrr38/jabot/plugin/handler/ReplaceHandler.java b/.../jabot-replace-handler/src/main/java/com/krrrr38/jabot/plugin/handler/ReplaceHandler.java
@@ -27,7 +27,7 @@ List<Rule> buildRules(Map<String, String> options) {
 
     private final Rule LIST_RULE =
             new Rule(
-                    Pattern.compile("\\Alist patterns\\z", Pattern.CASE_INSENSITIVE),
+                    Pattern.compile("\\A(list )?patterns\\z", Pattern.CASE_INSENSITIVE),
                     HANDLER_NAME,
                     "Show registered patterns to replace",
                     "replace patterns",

diff --git a/...ot-replace-handler/src/test/java/com/krrrr38/jabot/plugin/handler/ReplaceHandlerTest.java b/...ot-replace-handler/src/test/java/com/krrrr38/jabot/plugin/handler/ReplaceHandlerTest.java
@@ -37,6 +37,8 @@ public void testReceive() throws Exception {
 
         assertThat(handler.receive(null, "list patterns"), is(Optional.empty()));
         assertThat(queue.peekLast().getMessage(), containsString("No registered replace patterns"));
+        assertThat(handler.receive(null, "patterns"), is(Optional.empty()));
+        assertThat(queue.peekLast().getMessage(), containsString("No registered replace patterns"));
 
         assertThat(handler.receive(null, "replace foo with bar"), is(Optional.empty()));
         assertThat(queue.peekLast().getMessage(), containsString("Registered pattern"));

diff --git a/plugins/jabot-task-handler/README.md b/plugins/jabot-task-handler/README.md
@@ -3,7 +3,7 @@
 task management handler for __message sender__
 
 ```sh
-list tasks
+list tasks # or `tasks`
 add task <message>
 delete task <index:\\d+>
 delete all tasks

diff --git a/plugins/jabot-task-handler/src/main/java/com/krrrr38/jabot/plugin/handler/TaskHandler.java b/plugins/jabot-task-handler/src/main/java/com/krrrr38/jabot/plugin/handler/TaskHandler.java
@@ -33,7 +33,7 @@ List<Rule> buildRules(Map<String, String> options) {
 
     private final Rule LIST_TASKS =
             new Rule(
-                    Pattern.compile("\\Alist tasks\\z", Pattern.CASE_INSENSITIVE),
+                    Pattern.compile("\\A(list )?tasks\\z", Pattern.CASE_INSENSITIVE),
                     HANDLER_NAME,
                     "Show user's task list",
                     "list tasks",

diff --git a/...ns/jabot-task-handler/src/test/java/com/krrrr38/jabot/plugin/handler/TaskHandlerTest.java b/...ns/jabot-task-handler/src/test/java/com/krrrr38/jabot/plugin/handler/TaskHandlerTest.java
@@ -40,6 +40,8 @@ public void testReceive() throws Exception {
 
         assertThat(handler.receive(sender, "list tasks"), is(Optional.empty()));
         assertThat(queue.peekLast().getMessage(), containsString("No registered tasks"));
+        assertThat(handler.receive(sender, "tasks"), is(Optional.empty()));
+        assertThat(queue.peekLast().getMessage(), containsString("No registered tasks"));
 
         assertThat(handler.receive(sender, "add task message1"), is(Optional.empty()));
         assertThat(queue.peekLast().getMessage(), containsString("Registered new task"));