Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a script to generate a csv with the metrics gathered using prometheus queries for RM #1417

Open
wants to merge 2 commits into
base: mvp_demo
Choose a base branch
from

Conversation

kusumachalasani
Copy link
Contributor

Description

Include a script to generate a csv with the metrics gathered using prometheus queries for RM.

Fixes # (issue)

Type of change

  • Bug fix
  • [ X] New feature
  • Docs update
  • Breaking change (What changes might users need to make in their application due to this PR?)
  • Requires DB changes

How has this been tested?

Ran the script to generate a csv with metrics that works with RM.

  • New Test X
  • Functional testsuite

Test Configuration

  • Kubernetes clusters tested on:
    openshift

Checklist 🎯

  • [X ] Followed coding guidelines
  • [ X] Comments added
  • Dependent changes merged
  • Documentation updated
  • Tests added or updated

Additional information

Include any additional information such as links, test results, screenshots here

@kusumachalasani kusumachalasani self-assigned this Dec 10, 2024
@kusumachalasani kusumachalasani marked this pull request as ready for review December 10, 2024 18:25
@chandrams
Copy link
Contributor

@kusumachalasani

I get these errors on my system, when I pass the csv generated to recommendations infra script

Placed the csv in ./recommendations_demo/local/ folder

./recommendations_demo.sh -c openshift -o quay.io/kruize/autotune_operator:0.3 --dataDrivenRecommendations --dataDir="./recommendations_demo/local/" --mode=crc

Running the recommendation Infra demo with the existing data in crc mode...
Inserting the results in kruize from :  ./recommendations_demo/local/
Running the results of crc mode......
Aggregating the data for file :  ./recommendations_demo/local/pod_metrics.csv
Traceback (most recent call last):
  File "<string>", line 1, in <module>
    import recommendations_demo.recommendation_validation; recommendations_demo.recommendation_validation.aggregateWorkloads("./recommendations_demo/local/pod_metrics.csv", "metrics.csv")
                                                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/csubrama/kruize-demos/monitoring/remote_monitoring_demo/recommendations_infra_demo/recommendations_demo/recommendation_validation.py", line 178, in aggregateWorkloads
    agg_df = agg_df.append(df)
             ^^^^^^^^^^^^^
  File "/usr/lib64/python3.13/site-packages/pandas/core/generic.py", line 6296, in __getattr__
    return object.__getattribute__(self, name)
           ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
AttributeError: 'DataFrame' object has no attribute 'append'. Did you mean: '_append'?
sed: can't read metrics.csv: No such file or directory
sed: can't read metrics.csv: No such file or directory
sed: can't read metrics.csv: No such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants