Fix another issue with attribute lists (with multiple ‘=’ signs)

ksato9700 · Jun 13, 2016 · 4fc04c6 · 4fc04c6
1 parent a96fee0
commit 4fc04c6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/markdown/extensions/attr_list.py b/markdown/extensions/attr_list.py
@@ -32,17 +32,17 @@
 
 
 def _handle_double_quote(s, t):
-    k, v = t.split('=')
+    k, v = t.split('=', 1)
     return k, v.strip('"')
 
 
 def _handle_single_quote(s, t):
-    k, v = t.split('=')
+    k, v = t.split('=', 1)
     return k, v.strip("'")
 
 
 def _handle_key_value(s, t):
-    return t.split('=')
+    return t.split('=', 1)
 
 
 def _handle_word(s, t):

diff --git a/tests/extensions/attr_list.html b/tests/extensions/attr_list.html
@@ -64,5 +64,6 @@ <h1>Bad attributes</h1>
 <p>No <em>key or value</em></p>
 <p><em>Weirdness</em></p>
 <p><em>More weirdness</em></p>
+<p>This should not cause a <em foo="a=b">crash</em></p>
 <p>Attr_lists do not contain <em>newlines</em>{ foo=bar
 key=value }</p>
diff --git a/tests/extensions/attr_list.txt b/tests/extensions/attr_list.txt
@@ -88,5 +88,7 @@ No *key or value*{ = }
 
 *More weirdness*{ === }
 
+This should not cause a *crash*{ foo=a=b }
+
 Attr_lists do not contain *newlines*{ foo=bar
 key=value }