Squiz.PHP.DisallowMultipleAssignmentsSniff: Ignore default value assi…

…gnments in arrow functions
ktomk · Apr 8, 2021 · 9ca9a54 · 9ca9a54
1 parent b245bb3
commit 9ca9a54
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/Standards/Squiz/Sniffs/PHP/DisallowMultipleAssignmentsSniff.php b/src/Standards/Squiz/Sniffs/PHP/DisallowMultipleAssignmentsSniff.php
@@ -43,7 +43,7 @@ public function process(File $phpcsFile, $stackPtr)
         $tokens = $phpcsFile->getTokens();
 
         // Ignore default value assignments in function definitions.
-        $function = $phpcsFile->findPrevious([T_FUNCTION, T_CLOSURE], ($stackPtr - 1), null, false, null, true);
+        $function = $phpcsFile->findPrevious([T_FUNCTION, T_CLOSURE, T_FN], ($stackPtr - 1), null, false, null, true);
         if ($function !== false) {
             $opener = $tokens[$function]['parenthesis_opener'];
             $closer = $tokens[$function]['parenthesis_closer'];

diff --git a/src/Standards/Squiz/Tests/PHP/DisallowMultipleAssignmentsUnitTest.inc b/src/Standards/Squiz/Tests/PHP/DisallowMultipleAssignmentsUnitTest.inc
@@ -87,3 +87,5 @@ $array = [
         false => 0
     },
 ];
+
+$arrow_function = fn ($a = null) => $a;
-Original file line number
+Diff line change
@@ Expand Up / @@ -87,3 +87,5 @@ $array = [ @@
             false => 0
         },
     ];
+    $arrow_function = fn ($a = null) => $a;