-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 10.1.0 #1091
Release 10.1.0 #1091
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one issue. Otherwise LGTM
@@ -1657,7 +1657,7 @@ def patch_cluster_custom_object_with_http_info(self, group, version, plural, nam | |||
|
|||
# HTTP header `Content-Type` | |||
header_params['Content-Type'] = self.api_client.\ | |||
select_header_content_type(['application/merge-patch+json', 'application/json-patch+json']) | |||
select_header_content_type(['application/json-patch+json', 'application/merge-patch+json']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a known issue that breaks existing clients. Could you restore the custom object patch behavior following https://github.com/kubernetes-client/python/blob/master/devel/release.md#hot-issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every time I think I've finally learned how to read I prove myself wrong
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabianvf, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick v10.1.0 changelog from #1091
Pulls in #1073 to prevent hangs during garbage collection