Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yamllint enhancement #2072

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Yamllint enhancement #2072

merged 1 commit into from
Jan 17, 2025

Conversation

priyanshikhetwani
Copy link
Contributor

@priyanshikhetwani priyanshikhetwani commented Nov 26, 2024 •
edited
Loading

What this PR does / why we need it: Enhance linting to cover yaml files (to avoid issues as - 7cd7fcc)

Fixes #1497

Test Workflow:

Screenshot 2024-11-27 at 1 49 52 AM

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 26, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @priyanshikhetwani. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 26, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 26, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit af23a4c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/6789f46f8640240008e15f33
😎 Deploy Preview https://deploy-preview-2072--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@priyanshikhetwani priyanshikhetwani force-pushed the yamllint-enhancement branch 2 times, most recently from 33c5e87 to aea5586 Compare November 26, 2024 20:10
@priyanshikhetwani priyanshikhetwani mentioned this pull request Nov 27, 2024
Closed
@priyanshikhetwani priyanshikhetwani changed the title WIP: Yamllint enhancement Yamllint enhancement Nov 28, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2024
@priyanshikhetwani priyanshikhetwani changed the title Yamllint enhancement WIP: Yamllint enhancement Nov 29, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2024
@priyanshikhetwani priyanshikhetwani changed the title WIP: Yamllint enhancement Yamllint enhancement Nov 29, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2024
@mkumatag
Copy link
Member

mkumatag commented Dec 3, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 3, 2024
@Amulyam24
Copy link
Contributor

Hi @priyanshikhetwani, I see that 2 PRs are open for yamllint, can you please close one which is not needed anymore?

@priyanshikhetwani
Copy link
Contributor Author

Hi @priyanshikhetwani, I see that 2 PRs are open for yamllint, can you please close one which is not needed anymore?

Closed 2013

@Amulyam24
Copy link
Contributor

/retest

1 similar comment
@priyanshikhetwani
Copy link
Contributor Author

/retest

@Prajyot-Parab
Copy link
Contributor

lgtm
/cc @Amulyam24 for your final review.

Amulyam24
Amulyam24 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@Amulyam24 Amulyam24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you @priyanshikhetwani!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2025
@Prajyot-Parab
Copy link
Contributor

/approve
Thank You @priyanshikhetwani

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, Prajyot-Parab, priyanshikhetwani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit f9d7ade into kubernetes-sigs:main Jan 17, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prajyot-Parab Prajyot-Parab Prajyot-Parab left review comments

@Amulyam24 Amulyam24 Amulyam24 approved these changes

@Karthik-K-N Karthik-K-N Awaiting requested review from Karthik-K-N

Assignees

@Amulyam24 Amulyam24

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance linting to cover yaml files
6 participants
@priyanshikhetwani @k8s-ci-robot @mkumatag @Amulyam24 @Prajyot-Parab @yuanning6