-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumped go.mod version in tools #2095
Bumped go.mod version in tools #2095
Conversation
Hi @anshuman-agarwala. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hack/tools/go.mod
Outdated
@@ -1,6 +1,6 @@ | |||
module sigs.k8s.io/cluster-api-provider-ibmcloud/hack/tools | |||
|
|||
go 1.22.0 | |||
go 1.22.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right now we are using 1.22.9
version, we need to limit to that or bump the version for the project before this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed version from 1.22.10
to 1.22.9
to be in line with our go version.
9b93e74
to
b4aff91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anshuman-agarwala, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/lgtm |
What this PR does / why we need it: Fixes the lint failure here: #2071
This is happening because dependabot does not update the go.mod version automatically and our CI checks that running
go mod tidy
does not make any further changes to the go.mod file. The version change is happening because go-lint depends on version 1.22.1 which is due to this dependency in go-lint: honnef.co/go/toolsWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/area provider/ibmcloud
Release note: