Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Run devstack on ubuntu 24.04 #2302

Merged

Conversation

lentzi90
Copy link
Contributor

@lentzi90 lentzi90 commented Dec 4, 2024

What this PR does / why we need it:

This is an attempt to make it more stable.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 4, 2024
Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 0a28aae
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6751fd44022a990008aaf586
😎 Deploy Preview https://deploy-preview-2302--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lentzi90
Copy link
Contributor Author

lentzi90 commented Dec 4, 2024

Dec 04 06:43:40 capo-e2e-controller.c.k8s-infra-e2e-boskos-044.internal cloud-init[1504]: WARNING: this script has not been tested on noble
Dec 04 06:43:40 capo-e2e-controller.c.k8s-infra-e2e-boskos-044.internal cloud-init[1504]: +stack.sh:main:237                        �[m� [[ '' != \y\e\s ]]
Dec 04 06:43:40 capo-e2e-controller.c.k8s-infra-e2e-boskos-044.internal cloud-init[1504]: +stack.sh:main:238                        �[m� die 238 'If you wish to run this script anyway run with FORCE=yes'
Dec 04 06:43:40 capo-e2e-controller.c.k8s-infra-e2e-boskos-044.internal cloud-init[1504]: +functions-common:die:285                 �[m� local exitcode=0
Dec 04 06:43:40 capo-e2e-controller.c.k8s-infra-e2e-boskos-044.internal cloud-init[1504]: +functions-common:die:286                 �[m� set +o xtrace
Dec 04 06:43:40 capo-e2e-controller.c.k8s-infra-e2e-boskos-044.internal cloud-init[1504]: [Call Trace]
Dec 04 06:43:40 capo-e2e-controller.c.k8s-infra-e2e-boskos-044.internal cloud-init[1504]: /opt/stack/devstack/stack.sh:238:die
Dec 04 06:43:40 capo-e2e-controller.c.k8s-infra-e2e-boskos-044.internal cloud-init[1504]: [ERROR] /opt/stack/devstack/stack.sh:238 If you wish to run this script anyway run with FORCE=yes

Not promising 😞

@lentzi90 lentzi90 force-pushed the lentzi90/devstack-ubuntu-2404 branch from ea9a686 to 4ef5ad5 Compare December 4, 2024 07:05
@lentzi90
Copy link
Contributor Author

lentzi90 commented Dec 4, 2024

Hmm devstack came up. One test (flatcar) ended up with a control plane node in ERROR state. This failed the test and the cleanup.
Worth a retry I think!
/test pull-cluster-api-provider-openstack-e2e-test

@lentzi90
Copy link
Contributor Author

lentzi90 commented Dec 4, 2024

😮‍💨
Trying a few times to see if it is any better than what we currently have.
/test pull-cluster-api-provider-openstack-e2e-test

@lentzi90
Copy link
Contributor Author

lentzi90 commented Dec 4, 2024

/test pull-cluster-api-provider-openstack-e2e-test

@EmilienM
Copy link
Contributor

EmilienM commented Dec 4, 2024

@lentzi90 lentzi90 force-pushed the lentzi90/devstack-ubuntu-2404 branch from 4ef5ad5 to e4642d0 Compare December 5, 2024 11:28
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 5, 2024
@lentzi90
Copy link
Contributor Author

lentzi90 commented Dec 5, 2024

Ok all the other tests passed when I disabled flatcar and flatcar-sysext. Then it failed to kill sshuttle I think...?
This is a bit encouraging at least

lentzi90 and others added 2 commits December 5, 2024 21:21
This is an attempt to make it more stable.

Signed-off-by: Lennart Jern <[email protected]>
While we investigate the issues with flatcar images further [1].

[1] https://bugs.launchpad.net/nova/+bug/2091114

Signed-off-by: Stephen Finucane <[email protected]>
@lentzi90 lentzi90 force-pushed the lentzi90/devstack-ubuntu-2404 branch from e4642d0 to 0a28aae Compare December 5, 2024 19:21
@lentzi90
Copy link
Contributor Author

lentzi90 commented Dec 5, 2024

/test pull-cluster-api-provider-openstack-e2e-test

@EmilienM
Copy link
Contributor

EmilienM commented Dec 5, 2024

/hold cancel
/lgtm
/approve
/cherry-pick release-0.11
/cherry-pick release-0.10

@k8s-infra-cherrypick-robot

@EmilienM: once the present PR merges, I will cherry-pick it on top of release-0.10, release-0.11 in new PRs and assign them to you.

In response to this:

/hold cancel
/lgtm
/approve
/cherry-pick release-0.11
/cherry-pick release-0.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit cf34c5a into kubernetes-sigs:main Dec 5, 2024
9 checks passed
@k8s-infra-cherrypick-robot

@EmilienM: #2302 failed to apply on top of branch "release-0.11":

Applying: Run devstack on ubuntu 24.04 and bump to 2024.2
Using index info to reconstruct a base tree...
M	hack/ci/create_devstack.sh
A	hack/ci/libvirt.sh
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): hack/ci/libvirt.sh deleted in HEAD and modified in Run devstack on ubuntu 24.04 and bump to 2024.2. Version Run devstack on ubuntu 24.04 and bump to 2024.2 of hack/ci/libvirt.sh left in tree.
Auto-merging hack/ci/create_devstack.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Run devstack on ubuntu 24.04 and bump to 2024.2

In response to this:

/hold cancel
/lgtm
/approve
/cherry-pick release-0.11
/cherry-pick release-0.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@EmilienM: #2302 failed to apply on top of branch "release-0.10":

Applying: Run devstack on ubuntu 24.04 and bump to 2024.2
Using index info to reconstruct a base tree...
M	hack/ci/create_devstack.sh
A	hack/ci/libvirt.sh
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): hack/ci/libvirt.sh deleted in HEAD and modified in Run devstack on ubuntu 24.04 and bump to 2024.2. Version Run devstack on ubuntu 24.04 and bump to 2024.2 of hack/ci/libvirt.sh left in tree.
Auto-merging hack/ci/create_devstack.sh
CONFLICT (content): Merge conflict in hack/ci/create_devstack.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Run devstack on ubuntu 24.04 and bump to 2024.2

In response to this:

/hold cancel
/lgtm
/approve
/cherry-pick release-0.11
/cherry-pick release-0.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@EmilienM: #2302 failed to apply on top of branch "release-0.10":

Applying: Run devstack on ubuntu 24.04 and bump to 2024.2
Using index info to reconstruct a base tree...
M	hack/ci/create_devstack.sh
A	hack/ci/libvirt.sh
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): hack/ci/libvirt.sh deleted in HEAD and modified in Run devstack on ubuntu 24.04 and bump to 2024.2. Version Run devstack on ubuntu 24.04 and bump to 2024.2 of hack/ci/libvirt.sh left in tree.
Auto-merging hack/ci/create_devstack.sh
CONFLICT (content): Merge conflict in hack/ci/create_devstack.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Run devstack on ubuntu 24.04 and bump to 2024.2

In response to this:

/cherry-pick release-0.11
/cherry-pick release-0.10
/cherry-pick release-0.11
/cherry-pick release-0.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@EmilienM
Copy link
Contributor

EmilienM commented Dec 6, 2024

CI is not passing on the backports, so I'm trying combined cherry-picks to align the stars.

@lentzi90 lentzi90 deleted the lentzi90/devstack-ubuntu-2404 branch December 6, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants