Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 ci/devstack: host tuning #2307

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

EmilienM
Copy link
Contributor

@EmilienM EmilienM commented Dec 9, 2024

What this PR does / why we need it:

Configuring the following in devstack:

ENABLE_SYSCTL_MEM_TUNING="True"
ENABLE_SYSCTL_NET_TUNING="True"
ENABLE_ZSWAP="True"

That tuning is what is done in the devstack-platform-ubuntu-noble
job.
Example:
https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_d17/936669/2/check/devstack-platform-ubuntu-noble/d178dad/controller/logs/local_conf.txt

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 9, 2024
@k8s-ci-robot k8s-ci-robot requested a review from jichenjc December 9, 2024 13:34
@EmilienM EmilienM changed the title ci/devstack: host tunning 🐛 ci/devstack: host tunning Dec 9, 2024
@k8s-ci-robot k8s-ci-robot requested a review from lentzi90 December 9, 2024 13:34
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 9, 2024
Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 5eb8b23
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6756f24a7ab09400086916ff
😎 Deploy Preview https://deploy-preview-2307--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EmilienM EmilienM changed the title 🐛 ci/devstack: host tunning 🐛 ci/devstack: host tuning Dec 9, 2024
Configuring the following in devstack:

```
ENABLE_SYSCTL_MEM_TUNING="True"
ENABLE_SYSCTL_NET_TUNING="True"
ENABLE_ZSWAP="True"
```

That tuning is what is done in the `devstack-platform-ubuntu-noble`
job.
Example:
https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_d17/936669/2/check/devstack-platform-ubuntu-noble/d178dad/controller/logs/local_conf.txt
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2024
@EmilienM
Copy link
Contributor Author

EmilienM commented Dec 9, 2024

/hold
I want to run a few runs before we merge it. I want to see whether or not it actually helps.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2024
@EmilienM
Copy link
Contributor Author

EmilienM commented Dec 9, 2024

/test pull-cluster-api-provider-openstack-e2e-test

1 similar comment
@EmilienM
Copy link
Contributor Author

EmilienM commented Dec 9, 2024

/test pull-cluster-api-provider-openstack-e2e-test

@EmilienM
Copy link
Contributor Author

EmilienM commented Dec 9, 2024

3 successful runs in a row with no failure, let's merge it and see how that helps.

@EmilienM
Copy link
Contributor Author

EmilienM commented Dec 9, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2024
@EmilienM
Copy link
Contributor Author

EmilienM commented Dec 9, 2024

/hold cancel
/cherry-pick release-0.11
/cherry-pick release-0.10

@k8s-infra-cherrypick-robot

@EmilienM: once the present PR merges, I will cherry-pick it on top of release-0.10, release-0.11 in new PRs and assign them to you.

In response to this:

/hold cancel
/cherry-pick release-0.11
/cherry-pick release-0.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit 70b3eec into kubernetes-sigs:main Dec 9, 2024
9 checks passed
@k8s-infra-cherrypick-robot

@EmilienM: new pull request created: #2308

In response to this:

/hold cancel
/cherry-pick release-0.11
/cherry-pick release-0.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@EmilienM: new pull request created: #2309

In response to this:

/hold cancel
/cherry-pick release-0.11
/cherry-pick release-0.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants