Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pdns): add validation for MX and SRV records #4871

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

julillae
Copy link
Contributor

Description
Adds a check to validate the format of MX and SRV records. In addition, implements AdjustEndpoints to filter incorrectly formatted records which we know will fail to be created by PowerDNS. This change improves error handling for MX and SRV records and provides a base to validate other record types in the future.

Fixes #ISSUE

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign raffo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 13, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @julillae. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 13, 2024
@mloiseleur
Copy link
Contributor

Thanks for this PR, which is tested.
I'm wondering: the format check based on RFC may be used by other providers.
Wdyt of moving the checkEndpoint part in endpoint/endpoint.go ?

@mloiseleur
Copy link
Contributor

/retitle feat(pdns): add validation for MX and SRV records

@k8s-ci-robot k8s-ci-robot changed the title Add validation for MX and SRV records in pdns feat(pdns): add validation for MX and SRV records Nov 14, 2024
@julillae
Copy link
Contributor Author

@mloiseleur That is a great point! I moved the checkEndpoint function to endpoint/endpoint.go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants