-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve sources' docs to mention '--managed-record-types' #4882
base: master
Are you sure you want to change the base?
Improve sources' docs to mention '--managed-record-types' #4882
Conversation
* Also add some CRD examples for AWS and Cloudflare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @juan-vg! |
Hi @juan-vg. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thanks for this PR @juan-vg
|
That's definitely a good idea to stay DRY. However, when you refer to "Contribution>CRD Source" do you mean the tutorials? |
* Also move example to CRD-source doc
@mloiseleur done! Please let me know if there's something else I could do to improve the PR |
Description
Docs are lacking info about the
--managed-record-types
flag, especially for the record types that are not managed by default. This change improves the sources' docs to mention this flag and also adds some CRD examples for AWS and Cloudflare (other providers should be addressed also) while warning users that some record types must be explicitly allowed to be managed.Fixes #4831
Checklist