🌱 fix testdata generation #4569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
camilamacedo86
merged commit d7321e5
into
kubernetes-sigs:master
22 of 26 checks passed
camilamacedo86
added a commit
that referenced
this pull request
Feb 21, 2025
* Make kubebuilder go-installable Closes 4079 (Make kubebuilder go install-able) Signed-off-by: Miguel Elias dos Santos <[email protected]> * 🐛 Fix Kubernetes version in the goreleaser by upgrading it from 1.31.0 to 1.32.0 * fix: webhook testEnv Signed-off-by: Mateus Oliveira <[email protected]> * fix: disallow files containing unwanted extension files when initializing a project * 📖 Bump sigs.k8s.io/kubebuilder/v4 Bumps [sigs.k8s.io/kubebuilder/v4](https://github.com/kubernetes-sigs/kubebuilder) from 4.4.0 to 4.5.0. - [Release notes](https://github.com/kubernetes-sigs/kubebuilder/releases) - [Changelog](https://github.com/kubernetes-sigs/kubebuilder/blob/master/RELEASE.md) - [Commits](v4.4.0...v4.5.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/kubebuilder/v4 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * test: add to commmon.sh the latest k8s release 1.32 * Update yamllint target to handle missing dist/chart * doc: update the Artifacts with the latest changes on the EnvTest Makefile target configurations * ✨ Upgrade controller-runtime from v0.20.0 to v0.20.1 (#4528) Upgrade controller-runtime from v0.20.0 to v0.20.1 * 📖 bump github.com/spf13/pflag Bumps [github.com/spf13/pflag](https://github.com/spf13/pflag) from 1.0.5 to 1.0.6. - [Release notes](https://github.com/spf13/pflag/releases) - [Commits](spf13/pflag@v1.0.5...v1.0.6) --- updated-dependencies: - dependency-name: github.com/spf13/pflag dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * 🌱 bump github.com/spf13/pflag from 1.0.5 to 1.0.6 Bumps [github.com/spf13/pflag](https://github.com/spf13/pflag) from 1.0.5 to 1.0.6. - [Release notes](https://github.com/spf13/pflag/releases) - [Commits](spf13/pflag@v1.0.5...v1.0.6) --- updated-dependencies: - dependency-name: github.com/spf13/pflag dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * fix: correct minor typos in documentation * Removed Prometheus dependency from e2e scaffolds * 🐛(kustomize/v2): fix ServiceMonitor with TLS kustomize scaffolding * 📖 Remove simplistic advice about multiple controllers reconciling same CR (#4537) Remove simplistic advice about multiple controllers reconciling same CR This advice is simplyfing things and making an "It depends" situation look like there was a clear good and a clear bad way that is the same in all situations. Pretty much none of the issues stated will get better if each controller gets its own CR: * Race conditions: Conflict errors can always happen and all controllers need to be able to deal with them. If a full reconciliation is too expensive, they can use something like `retry.OnConflict` * Concurrency issues with different interpretations of state: This example sounds like just buggy software. Copying the state to a new CR doesn't eliminate this problem * Maintenance and support difficulties: This is definitely not going to get any better by adding more CRDs into the mix, if anything, it will get more complicated * Status tracking complications: This is why conditions exist and Kubernetes api guidelines explicitly state that controllers need to ignore unknown conditions: `Objects may report multiple conditions, and new types of conditions may be added in the future or by 3rd party controllers.`, [ref][0] * Performance issues: If multiple controllers do the same thing, that is a bug regardless of all other considerations and can easily lead to correctness and performance issues. The `workqueue` locks items while they are reconciled to avoid exactly that, but obviously it doesn't work cross-controller To illustrate the situation, think about the `Pod` object, in the lifecycle of a pod we usually have at least cluster-autoscaler, scheduler and kubelet. Making cluster-autoscaler act on a `PodScaleRequest` and scheduler on a `PodScheduleRequest` would be a complication, not a simplification. [0]: https://github.com/kubernetes/community/blob/322066e7dba7c5043071392fec427a57f8660734/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties * 🌱 ci: fix testdata - issues caused by some merge conflict with go mod (#4538) ci: fix testdata - issues caused by some merge conflict with go mod * Revert "Merge pull request #4512 from sarthaksarthak9/lint" (#4539) This reverts commit ded393e, reversing changes made to 543b4a1. * add context.Context to EnqueuRequestsFromMapFunc The underlying `TypedMapFunc` requires this argument, reference https://github.com/kubernetes-sigs/controller-runtime/blob/main/pkg/handler/enqueue_mapped.go#L36 * 🌱 bump golang.org/x/text from 0.21.0 to 0.22.0 Bumps [golang.org/x/text](https://github.com/golang/text) from 0.21.0 to 0.22.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.21.0...v0.22.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * handle missing boilerplate file gracefully * 📖 Fix grammar in lets -> let's. * Update controller-runtime version used in the common.sh tests * Update Roadmap 2025 with latest status * 🌱 Improve samples linting & fix samples lint issues This commit includes: - Fix linter issues - Refactor fetchCronJob in sample controller reconcile func - Fix getting-started tutorial lint issues - Fix multiversion tutorial lint issues - Fix cronjob-tutorial lint issues - Refactor cronjob controller reconcile to reduce cyclomatic complexity * Revert "🐛 (kustomize/v2): fix ServiceMonitor with TLS kustomize scaffolding" * 🌱 Bump golang.org/x/tools from 0.29.0 to 0.30.0 Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.29.0 to 0.30.0. - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.29.0...v0.30.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * ✨ Upgrade controller-gen from v0.17.1 to v0.17.2 (#4553) Upgrade controller-gen from v0.17.1 to v0.17.2 * (go/v4,ksutomize/v2,helm/v1-alpha): Fix prometheus integration with TLS check Co-Author: Abhisek Dwivedi <[email protected]> * Update alpha generate command so that --repo is always included when running kubebuilder init to fix issue when not on GOPATH * 🌱 fix testdata generation (#4569) fix testdata generation * 🌱 Bump github.com/spf13/cobra from 1.8.1 to 1.9.1 Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.8.1 to 1.9.1. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.8.1...v1.9.1) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * ✨ Upgrade controller-runtime from v0.20.1 to v0.20.2 (#4570) Upgrade controller-runtime from v0.20.1 to v0.20.2 and K8s version from v1.32.0 to 1.32.1 * Added e2e tests for alpha generate command for scaffolded data under testdata changes due to running make generate --------- Signed-off-by: Miguel Elias dos Santos <[email protected]> Signed-off-by: Mateus Oliveira <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Miguel Elias dos Santos <[email protected]> Co-authored-by: Kubernetes Prow Robot <[email protected]> Co-authored-by: Mateus Oliveira <[email protected]> Co-authored-by: Afzal Ansari <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sarthaksarthak9 <[email protected]> Co-authored-by: sapphire <[email protected]> Co-authored-by: Anshuman <[email protected]> Co-authored-by: Abhisek Dwivedi <[email protected]> Co-authored-by: Alvaro Aleman <[email protected]> Co-authored-by: mwdomino <[email protected]> Co-authored-by: Thomas Guettler <[email protected]> Co-authored-by: Wazery <[email protected]> Co-authored-by: Freddy Esteban Perez <[email protected]> Co-authored-by: Manali Latkar <[email protected]>
camilamacedo86
added a commit
that referenced
this pull request
Feb 21, 2025
* Make kubebuilder go-installable Closes 4079 (Make kubebuilder go install-able) Signed-off-by: Miguel Elias dos Santos <[email protected]> * 🐛 Fix Kubernetes version in the goreleaser by upgrading it from 1.31.0 to 1.32.0 * fix: webhook testEnv Signed-off-by: Mateus Oliveira <[email protected]> * fix: disallow files containing unwanted extension files when initializing a project * 📖 Bump sigs.k8s.io/kubebuilder/v4 Bumps [sigs.k8s.io/kubebuilder/v4](https://github.com/kubernetes-sigs/kubebuilder) from 4.4.0 to 4.5.0. - [Release notes](https://github.com/kubernetes-sigs/kubebuilder/releases) - [Changelog](https://github.com/kubernetes-sigs/kubebuilder/blob/master/RELEASE.md) - [Commits](v4.4.0...v4.5.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/kubebuilder/v4 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * test: add to commmon.sh the latest k8s release 1.32 * Update yamllint target to handle missing dist/chart * doc: update the Artifacts with the latest changes on the EnvTest Makefile target configurations * ✨ Upgrade controller-runtime from v0.20.0 to v0.20.1 (#4528) Upgrade controller-runtime from v0.20.0 to v0.20.1 * 📖 bump github.com/spf13/pflag Bumps [github.com/spf13/pflag](https://github.com/spf13/pflag) from 1.0.5 to 1.0.6. - [Release notes](https://github.com/spf13/pflag/releases) - [Commits](spf13/pflag@v1.0.5...v1.0.6) --- updated-dependencies: - dependency-name: github.com/spf13/pflag dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * 🌱 bump github.com/spf13/pflag from 1.0.5 to 1.0.6 Bumps [github.com/spf13/pflag](https://github.com/spf13/pflag) from 1.0.5 to 1.0.6. - [Release notes](https://github.com/spf13/pflag/releases) - [Commits](spf13/pflag@v1.0.5...v1.0.6) --- updated-dependencies: - dependency-name: github.com/spf13/pflag dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * fix: correct minor typos in documentation * Removed Prometheus dependency from e2e scaffolds * 🐛(kustomize/v2): fix ServiceMonitor with TLS kustomize scaffolding * 📖 Remove simplistic advice about multiple controllers reconciling same CR (#4537) Remove simplistic advice about multiple controllers reconciling same CR This advice is simplyfing things and making an "It depends" situation look like there was a clear good and a clear bad way that is the same in all situations. Pretty much none of the issues stated will get better if each controller gets its own CR: * Race conditions: Conflict errors can always happen and all controllers need to be able to deal with them. If a full reconciliation is too expensive, they can use something like `retry.OnConflict` * Concurrency issues with different interpretations of state: This example sounds like just buggy software. Copying the state to a new CR doesn't eliminate this problem * Maintenance and support difficulties: This is definitely not going to get any better by adding more CRDs into the mix, if anything, it will get more complicated * Status tracking complications: This is why conditions exist and Kubernetes api guidelines explicitly state that controllers need to ignore unknown conditions: `Objects may report multiple conditions, and new types of conditions may be added in the future or by 3rd party controllers.`, [ref][0] * Performance issues: If multiple controllers do the same thing, that is a bug regardless of all other considerations and can easily lead to correctness and performance issues. The `workqueue` locks items while they are reconciled to avoid exactly that, but obviously it doesn't work cross-controller To illustrate the situation, think about the `Pod` object, in the lifecycle of a pod we usually have at least cluster-autoscaler, scheduler and kubelet. Making cluster-autoscaler act on a `PodScaleRequest` and scheduler on a `PodScheduleRequest` would be a complication, not a simplification. [0]: https://github.com/kubernetes/community/blob/322066e7dba7c5043071392fec427a57f8660734/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties * 🌱 ci: fix testdata - issues caused by some merge conflict with go mod (#4538) ci: fix testdata - issues caused by some merge conflict with go mod * Revert "Merge pull request #4512 from sarthaksarthak9/lint" (#4539) This reverts commit ded393e, reversing changes made to 543b4a1. * add context.Context to EnqueuRequestsFromMapFunc The underlying `TypedMapFunc` requires this argument, reference https://github.com/kubernetes-sigs/controller-runtime/blob/main/pkg/handler/enqueue_mapped.go#L36 * 🌱 bump golang.org/x/text from 0.21.0 to 0.22.0 Bumps [golang.org/x/text](https://github.com/golang/text) from 0.21.0 to 0.22.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.21.0...v0.22.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * handle missing boilerplate file gracefully * 📖 Fix grammar in lets -> let's. * Update controller-runtime version used in the common.sh tests * Update Roadmap 2025 with latest status * 🌱 Improve samples linting & fix samples lint issues This commit includes: - Fix linter issues - Refactor fetchCronJob in sample controller reconcile func - Fix getting-started tutorial lint issues - Fix multiversion tutorial lint issues - Fix cronjob-tutorial lint issues - Refactor cronjob controller reconcile to reduce cyclomatic complexity * Revert "🐛 (kustomize/v2): fix ServiceMonitor with TLS kustomize scaffolding" * 🌱 Bump golang.org/x/tools from 0.29.0 to 0.30.0 Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.29.0 to 0.30.0. - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.29.0...v0.30.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * ✨ Upgrade controller-gen from v0.17.1 to v0.17.2 (#4553) Upgrade controller-gen from v0.17.1 to v0.17.2 * (go/v4,ksutomize/v2,helm/v1-alpha): Fix prometheus integration with TLS check Co-Author: Abhisek Dwivedi <[email protected]> * Update alpha generate command so that --repo is always included when running kubebuilder init to fix issue when not on GOPATH * 🌱 fix testdata generation (#4569) fix testdata generation * 🌱 Bump github.com/spf13/cobra from 1.8.1 to 1.9.1 Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.8.1 to 1.9.1. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.8.1...v1.9.1) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * ✨ Upgrade controller-runtime from v0.20.1 to v0.20.2 (#4570) Upgrade controller-runtime from v0.20.1 to v0.20.2 and K8s version from v1.32.0 to 1.32.1 * Added e2e tests for alpha generate command for scaffolded data under testdata changes due to running make generate --------- Signed-off-by: Miguel Elias dos Santos <[email protected]> Signed-off-by: Mateus Oliveira <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Miguel Elias dos Santos <[email protected]> Co-authored-by: Kubernetes Prow Robot <[email protected]> Co-authored-by: Mateus Oliveira <[email protected]> Co-authored-by: Afzal Ansari <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sarthaksarthak9 <[email protected]> Co-authored-by: sapphire <[email protected]> Co-authored-by: Anshuman <[email protected]> Co-authored-by: Abhisek Dwivedi <[email protected]> Co-authored-by: Alvaro Aleman <[email protected]> Co-authored-by: mwdomino <[email protected]> Co-authored-by: Thomas Guettler <[email protected]> Co-authored-by: Wazery <[email protected]> Co-authored-by: Freddy Esteban Perez <[email protected]> Co-authored-by: Manali Latkar <[email protected]>
camilamacedo86
added a commit
that referenced
this pull request
Feb 21, 2025
* Make kubebuilder go-installable Closes 4079 (Make kubebuilder go install-able) Signed-off-by: Miguel Elias dos Santos <[email protected]> * 🐛 Fix Kubernetes version in the goreleaser by upgrading it from 1.31.0 to 1.32.0 * fix: webhook testEnv Signed-off-by: Mateus Oliveira <[email protected]> * fix: disallow files containing unwanted extension files when initializing a project * 📖 Bump sigs.k8s.io/kubebuilder/v4 Bumps [sigs.k8s.io/kubebuilder/v4](https://github.com/kubernetes-sigs/kubebuilder) from 4.4.0 to 4.5.0. - [Release notes](https://github.com/kubernetes-sigs/kubebuilder/releases) - [Changelog](https://github.com/kubernetes-sigs/kubebuilder/blob/master/RELEASE.md) - [Commits](v4.4.0...v4.5.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/kubebuilder/v4 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * test: add to commmon.sh the latest k8s release 1.32 * Update yamllint target to handle missing dist/chart * doc: update the Artifacts with the latest changes on the EnvTest Makefile target configurations * ✨ Upgrade controller-runtime from v0.20.0 to v0.20.1 (#4528) Upgrade controller-runtime from v0.20.0 to v0.20.1 * 📖 bump github.com/spf13/pflag Bumps [github.com/spf13/pflag](https://github.com/spf13/pflag) from 1.0.5 to 1.0.6. - [Release notes](https://github.com/spf13/pflag/releases) - [Commits](spf13/pflag@v1.0.5...v1.0.6) --- updated-dependencies: - dependency-name: github.com/spf13/pflag dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * 🌱 bump github.com/spf13/pflag from 1.0.5 to 1.0.6 Bumps [github.com/spf13/pflag](https://github.com/spf13/pflag) from 1.0.5 to 1.0.6. - [Release notes](https://github.com/spf13/pflag/releases) - [Commits](spf13/pflag@v1.0.5...v1.0.6) --- updated-dependencies: - dependency-name: github.com/spf13/pflag dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * fix: correct minor typos in documentation * Removed Prometheus dependency from e2e scaffolds * 🐛(kustomize/v2): fix ServiceMonitor with TLS kustomize scaffolding * 📖 Remove simplistic advice about multiple controllers reconciling same CR (#4537) Remove simplistic advice about multiple controllers reconciling same CR This advice is simplyfing things and making an "It depends" situation look like there was a clear good and a clear bad way that is the same in all situations. Pretty much none of the issues stated will get better if each controller gets its own CR: * Race conditions: Conflict errors can always happen and all controllers need to be able to deal with them. If a full reconciliation is too expensive, they can use something like `retry.OnConflict` * Concurrency issues with different interpretations of state: This example sounds like just buggy software. Copying the state to a new CR doesn't eliminate this problem * Maintenance and support difficulties: This is definitely not going to get any better by adding more CRDs into the mix, if anything, it will get more complicated * Status tracking complications: This is why conditions exist and Kubernetes api guidelines explicitly state that controllers need to ignore unknown conditions: `Objects may report multiple conditions, and new types of conditions may be added in the future or by 3rd party controllers.`, [ref][0] * Performance issues: If multiple controllers do the same thing, that is a bug regardless of all other considerations and can easily lead to correctness and performance issues. The `workqueue` locks items while they are reconciled to avoid exactly that, but obviously it doesn't work cross-controller To illustrate the situation, think about the `Pod` object, in the lifecycle of a pod we usually have at least cluster-autoscaler, scheduler and kubelet. Making cluster-autoscaler act on a `PodScaleRequest` and scheduler on a `PodScheduleRequest` would be a complication, not a simplification. [0]: https://github.com/kubernetes/community/blob/322066e7dba7c5043071392fec427a57f8660734/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties * 🌱 ci: fix testdata - issues caused by some merge conflict with go mod (#4538) ci: fix testdata - issues caused by some merge conflict with go mod * Revert "Merge pull request #4512 from sarthaksarthak9/lint" (#4539) This reverts commit ded393e, reversing changes made to 543b4a1. * add context.Context to EnqueuRequestsFromMapFunc The underlying `TypedMapFunc` requires this argument, reference https://github.com/kubernetes-sigs/controller-runtime/blob/main/pkg/handler/enqueue_mapped.go#L36 * 🌱 bump golang.org/x/text from 0.21.0 to 0.22.0 Bumps [golang.org/x/text](https://github.com/golang/text) from 0.21.0 to 0.22.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.21.0...v0.22.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * handle missing boilerplate file gracefully * 📖 Fix grammar in lets -> let's. * Update controller-runtime version used in the common.sh tests * Update Roadmap 2025 with latest status * 🌱 Improve samples linting & fix samples lint issues This commit includes: - Fix linter issues - Refactor fetchCronJob in sample controller reconcile func - Fix getting-started tutorial lint issues - Fix multiversion tutorial lint issues - Fix cronjob-tutorial lint issues - Refactor cronjob controller reconcile to reduce cyclomatic complexity * Revert "🐛 (kustomize/v2): fix ServiceMonitor with TLS kustomize scaffolding" * 🌱 Bump golang.org/x/tools from 0.29.0 to 0.30.0 Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.29.0 to 0.30.0. - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.29.0...v0.30.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * ✨ Upgrade controller-gen from v0.17.1 to v0.17.2 (#4553) Upgrade controller-gen from v0.17.1 to v0.17.2 * (go/v4,ksutomize/v2,helm/v1-alpha): Fix prometheus integration with TLS check Co-Author: Abhisek Dwivedi <[email protected]> * Update alpha generate command so that --repo is always included when running kubebuilder init to fix issue when not on GOPATH * 🌱 fix testdata generation (#4569) fix testdata generation * 🌱 Bump github.com/spf13/cobra from 1.8.1 to 1.9.1 Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.8.1 to 1.9.1. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.8.1...v1.9.1) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * ✨ Upgrade controller-runtime from v0.20.1 to v0.20.2 (#4570) Upgrade controller-runtime from v0.20.1 to v0.20.2 and K8s version from v1.32.0 to 1.32.1 * Added e2e tests for alpha generate command for scaffolded data under testdata changes due to running make generate * Revert ":bug: Make kubebuilder go install-able" --------- Signed-off-by: Miguel Elias dos Santos <[email protected]> Signed-off-by: Mateus Oliveira <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Miguel Elias dos Santos <[email protected]> Co-authored-by: Kubernetes Prow Robot <[email protected]> Co-authored-by: Mateus Oliveira <[email protected]> Co-authored-by: Afzal Ansari <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sarthaksarthak9 <[email protected]> Co-authored-by: sapphire <[email protected]> Co-authored-by: Anshuman <[email protected]> Co-authored-by: Abhisek Dwivedi <[email protected]> Co-authored-by: Alvaro Aleman <[email protected]> Co-authored-by: mwdomino <[email protected]> Co-authored-by: Thomas Guettler <[email protected]> Co-authored-by: Wazery <[email protected]> Co-authored-by: Freddy Esteban Perez <[email protected]> Co-authored-by: Manali Latkar <[email protected]>
camilamacedo86
added a commit
that referenced
this pull request
Feb 21, 2025
…4578) * Make kubebuilder go-installable Closes 4079 (Make kubebuilder go install-able) Signed-off-by: Miguel Elias dos Santos <[email protected]> * 🐛 Fix Kubernetes version in the goreleaser by upgrading it from 1.31.0 to 1.32.0 * fix: webhook testEnv Signed-off-by: Mateus Oliveira <[email protected]> * fix: disallow files containing unwanted extension files when initializing a project * 📖 Bump sigs.k8s.io/kubebuilder/v4 Bumps [sigs.k8s.io/kubebuilder/v4](https://github.com/kubernetes-sigs/kubebuilder) from 4.4.0 to 4.5.0. - [Release notes](https://github.com/kubernetes-sigs/kubebuilder/releases) - [Changelog](https://github.com/kubernetes-sigs/kubebuilder/blob/master/RELEASE.md) - [Commits](v4.4.0...v4.5.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/kubebuilder/v4 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * test: add to commmon.sh the latest k8s release 1.32 * Update yamllint target to handle missing dist/chart * doc: update the Artifacts with the latest changes on the EnvTest Makefile target configurations * ✨ Upgrade controller-runtime from v0.20.0 to v0.20.1 (#4528) Upgrade controller-runtime from v0.20.0 to v0.20.1 * 📖 bump github.com/spf13/pflag Bumps [github.com/spf13/pflag](https://github.com/spf13/pflag) from 1.0.5 to 1.0.6. - [Release notes](https://github.com/spf13/pflag/releases) - [Commits](spf13/pflag@v1.0.5...v1.0.6) --- updated-dependencies: - dependency-name: github.com/spf13/pflag dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * 🌱 bump github.com/spf13/pflag from 1.0.5 to 1.0.6 Bumps [github.com/spf13/pflag](https://github.com/spf13/pflag) from 1.0.5 to 1.0.6. - [Release notes](https://github.com/spf13/pflag/releases) - [Commits](spf13/pflag@v1.0.5...v1.0.6) --- updated-dependencies: - dependency-name: github.com/spf13/pflag dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * fix: correct minor typos in documentation * Removed Prometheus dependency from e2e scaffolds * 🐛(kustomize/v2): fix ServiceMonitor with TLS kustomize scaffolding * 📖 Remove simplistic advice about multiple controllers reconciling same CR (#4537) Remove simplistic advice about multiple controllers reconciling same CR This advice is simplyfing things and making an "It depends" situation look like there was a clear good and a clear bad way that is the same in all situations. Pretty much none of the issues stated will get better if each controller gets its own CR: * Race conditions: Conflict errors can always happen and all controllers need to be able to deal with them. If a full reconciliation is too expensive, they can use something like `retry.OnConflict` * Concurrency issues with different interpretations of state: This example sounds like just buggy software. Copying the state to a new CR doesn't eliminate this problem * Maintenance and support difficulties: This is definitely not going to get any better by adding more CRDs into the mix, if anything, it will get more complicated * Status tracking complications: This is why conditions exist and Kubernetes api guidelines explicitly state that controllers need to ignore unknown conditions: `Objects may report multiple conditions, and new types of conditions may be added in the future or by 3rd party controllers.`, [ref][0] * Performance issues: If multiple controllers do the same thing, that is a bug regardless of all other considerations and can easily lead to correctness and performance issues. The `workqueue` locks items while they are reconciled to avoid exactly that, but obviously it doesn't work cross-controller To illustrate the situation, think about the `Pod` object, in the lifecycle of a pod we usually have at least cluster-autoscaler, scheduler and kubelet. Making cluster-autoscaler act on a `PodScaleRequest` and scheduler on a `PodScheduleRequest` would be a complication, not a simplification. [0]: https://github.com/kubernetes/community/blob/322066e7dba7c5043071392fec427a57f8660734/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties * 🌱 ci: fix testdata - issues caused by some merge conflict with go mod (#4538) ci: fix testdata - issues caused by some merge conflict with go mod * Revert "Merge pull request #4512 from sarthaksarthak9/lint" (#4539) This reverts commit ded393e, reversing changes made to 543b4a1. * add context.Context to EnqueuRequestsFromMapFunc The underlying `TypedMapFunc` requires this argument, reference https://github.com/kubernetes-sigs/controller-runtime/blob/main/pkg/handler/enqueue_mapped.go#L36 * 🌱 bump golang.org/x/text from 0.21.0 to 0.22.0 Bumps [golang.org/x/text](https://github.com/golang/text) from 0.21.0 to 0.22.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.21.0...v0.22.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * handle missing boilerplate file gracefully * 📖 Fix grammar in lets -> let's. * Update controller-runtime version used in the common.sh tests * Update Roadmap 2025 with latest status * 🌱 Improve samples linting & fix samples lint issues This commit includes: - Fix linter issues - Refactor fetchCronJob in sample controller reconcile func - Fix getting-started tutorial lint issues - Fix multiversion tutorial lint issues - Fix cronjob-tutorial lint issues - Refactor cronjob controller reconcile to reduce cyclomatic complexity * Revert "🐛 (kustomize/v2): fix ServiceMonitor with TLS kustomize scaffolding" * 🌱 Bump golang.org/x/tools from 0.29.0 to 0.30.0 Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.29.0 to 0.30.0. - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.29.0...v0.30.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * ✨ Upgrade controller-gen from v0.17.1 to v0.17.2 (#4553) Upgrade controller-gen from v0.17.1 to v0.17.2 * (go/v4,ksutomize/v2,helm/v1-alpha): Fix prometheus integration with TLS check Co-Author: Abhisek Dwivedi <[email protected]> * Update alpha generate command so that --repo is always included when running kubebuilder init to fix issue when not on GOPATH * 🌱 fix testdata generation (#4569) fix testdata generation * 🌱 Bump github.com/spf13/cobra from 1.8.1 to 1.9.1 Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.8.1 to 1.9.1. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.8.1...v1.9.1) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * ✨ Upgrade controller-runtime from v0.20.1 to v0.20.2 (#4570) Upgrade controller-runtime from v0.20.1 to v0.20.2 and K8s version from v1.32.0 to 1.32.1 * Added e2e tests for alpha generate command for scaffolded data under testdata changes due to running make generate * Revert ":bug: Make kubebuilder go install-able" --------- Signed-off-by: Miguel Elias dos Santos <[email protected]> Signed-off-by: Mateus Oliveira <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Miguel Elias dos Santos <[email protected]> Co-authored-by: Kubernetes Prow Robot <[email protected]> Co-authored-by: Mateus Oliveira <[email protected]> Co-authored-by: Afzal Ansari <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sarthaksarthak9 <[email protected]> Co-authored-by: sapphire <[email protected]> Co-authored-by: Anshuman <[email protected]> Co-authored-by: Abhisek Dwivedi <[email protected]> Co-authored-by: Alvaro Aleman <[email protected]> Co-authored-by: mwdomino <[email protected]> Co-authored-by: Thomas Guettler <[email protected]> Co-authored-by: Wazery <[email protected]> Co-authored-by: Freddy Esteban Perez <[email protected]> Co-authored-by: Manali Latkar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.