Fix trailing slash handling in FilterSpecByPathsWithoutSideEffects #520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #495.
This PR ensures that
FilterSpecByPathsWithoutSideEffects
works correctly with or without a trailing slash. For example, the input path/v1beta1
is no longer considered matching the prefix/v1
.In the meantime, we've made sure that exact matches are always kept, with or without a trailing slash. For example, before this fix,
/v1
would be filtered out if the prefix is specified as/v1/
, but with this fix it will be kept.