feat(scheduler): loadaware support nodemetric #25
Conversation
| @@ -1,19 +1,3 @@ | |||
| /* | |||
There was a problem hiding this comment.
why do you delete this ?
There was a problem hiding this comment.
It is a misoperation, and all headers have been restored
pkg/util/pod/util.go
Outdated
| @@ -682,6 +693,10 @@ func CanPodBePreempted(pod *v1.Pod) int { | |||
| return -1 | |||
| } | |||
|
|
|||
| func GetPodMetaName(pod *v1.Pod) string { | |||
There was a problem hiding this comment.
several functions are doing the same thing, don't add a new one
There was a problem hiding this comment.
fixed, use podutil.GetPodKey instead
| @@ -263,6 +263,8 @@ type PodInfoMaintainer struct { | |||
|
|
|||
| podsWithAffinity PodInfoSlice | |||
| podsWithRequiredAntiAffinity PodInfoSlice | |||
|
|
|||
| podsByMetaName map[string]*PodInfo | |||
There was a problem hiding this comment.
this is only used by LoadAware plugin ? I am thinking if we can create separate data structures for plugin specific metrics/info instead of putting all info together in one struct
There was a problem hiding this comment.
good point, as the maintenance operations of related pods have been delegated to NodeMetricInfo
binacs
force-pushed
the
dev/binacs/support-load-aware
branch
from
2da6edf to
3a57bd9
Compare
|
Split relevant code changes into two commits (vendor + feature), PTAL @NickrenREN |
binacs
force-pushed
the
dev/binacs/support-load-aware
branch
from
3a57bd9 to
918f3c9
Compare
binacs
force-pushed
the
dev/binacs/support-load-aware
branch
from
918f3c9 to
6f7c3cd
Compare
pkg/features/godel_features.go
Outdated
| @@ -72,6 +72,12 @@ const ( | |||
| // | |||
| // Allows colocation | |||
| EnableColocation featuregate.Feature = "EnableColocation" | |||
|
|
|||
There was a problem hiding this comment.
load aware is a plugin, why do we need a feature gate for it ?
There was a problem hiding this comment.
Removed the featuregate and enabled LoadAwareStore by default, ptal
There was a problem hiding this comment.
Thanks for this, we can merge this PR, and leave a TODO for you (as we discussed offline).
binacs
force-pushed
the
dev/binacs/support-load-aware
branch
from
6f7c3cd to
c7c7e08
Compare
close #22