HHVM removes invalid comments at the end of a file, as if they were n…

…ever there
kudeepak · Sep 7, 2016 · 66f3f2e · 66f3f2e
1 parent 67a31be
commit 66f3f2e
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 20 deletions.
diff --git a/CodeSniffer/Standards/Generic/Tests/Files/EndFileNewlineUnitTest.php b/CodeSniffer/Standards/Generic/Tests/Files/EndFileNewlineUnitTest.php
@@ -44,16 +44,18 @@ public function getErrorList($testFile='')
     {
         switch ($testFile) {
         case 'EndFileNewlineUnitTest.3.inc':
-        case 'EndFileNewlineUnitTest.4.inc':
         case 'EndFileNewlineUnitTest.3.js':
         case 'EndFileNewlineUnitTest.3.css':
-            return array(
-                    2 => 1,
-                   );
-            break;
+            return array(2 => 1);
+        case 'EndFileNewlineUnitTest.4.inc':
+            // HHVM just removes the entire comment token, as if it was never there.
+            if (defined('HHVM_VERSION') === true) {
+                return array();
+            }
+
+            return array(2 => 1);
         default:
             return array();
-            break;
         }//end switch
 
     }//end getErrorList()

diff --git a/CodeSniffer/Standards/Generic/Tests/Files/EndFileNoNewlineUnitTest.php b/CodeSniffer/Standards/Generic/Tests/Files/EndFileNoNewlineUnitTest.php
@@ -47,20 +47,26 @@ public function getErrorList($testFile='')
         case 'EndFileNoNewlineUnitTest.1.css':
         case 'EndFileNoNewlineUnitTest.1.js':
         case 'EndFileNoNewlineUnitTest.2.inc':
-            return array(
-                    3 => 1,
-                   );
-            break;
+            return array(3 => 1);
         case 'EndFileNoNewlineUnitTest.2.css':
         case 'EndFileNoNewlineUnitTest.2.js':
+            return array(2 => 1);
+        case 'EndFileNoNewlineUnitTest.5.inc':
+            // HHVM just removes the entire comment token, as if it was never there.
+            if (defined('HHVM_VERSION') === true) {
+                return array(1 => 1);
+            }
+
+            return array();
         case 'EndFileNoNewlineUnitTest.6.inc':
-            return array(
-                    2 => 1,
-                   );
-            break;
+            // HHVM just removes the entire comment token, as if it was never there.
+            if (defined('HHVM_VERSION') === true) {
+                return array(1 => 1);
+            }
+
+            return array(2 => 1);
         default:
             return array();
-            break;
         }//end switch
 
     }//end getErrorList()

diff --git a/CodeSniffer/Standards/PSR2/Tests/Files/EndFileNewlineUnitTest.php b/CodeSniffer/Standards/PSR2/Tests/Files/EndFileNewlineUnitTest.php
@@ -47,15 +47,17 @@ public function getErrorList($testFile='')
         case 'EndFileNewlineUnitTest.3.inc':
         case 'EndFileNewlineUnitTest.6.inc':
         case 'EndFileNewlineUnitTest.7.inc':
+            return array(2 => 1);
         case 'EndFileNewlineUnitTest.9.inc':
         case 'EndFileNewlineUnitTest.10.inc':
-            return array(
-                    2 => 1,
-                   );
-            break;
+            // HHVM just removes the entire comment token, as if it was never there.
+            if (defined('HHVM_VERSION') === true) {
+                return array();
+            }
+
+            return array(2 => 1);
         default:
             return array();
-            break;
         }//end switch
 
     }//end getErrorList()