Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: TabBarとSwitchの内部処理を整理 #5370

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
+74 −39
Open

chore: TabBarとSwitchの内部処理を整理 #5370

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4c45ff1
chore: TabButtonのstyleを調整
AtsushiM Feb 7, 2025
328e6ed
chore: TabButtonのonClickや内部をmemo化
AtsushiM Feb 7, 2025
125fcea
chore: TabBarのclassName生成を調整
AtsushiM Feb 7, 2025
343c860
chore: SwitchのclassName生成を調整
AtsushiM Feb 7, 2025
f060970
chore: SwitchのMemoizedSuffixIconを切り出す
AtsushiM Feb 7, 2025
4a0a2be
chore: SwitchのMemoizedLabelを切り出す
AtsushiM Feb 7, 2025
5638eab
chore: fix ci
AtsushiM Feb 7, 2025
989c12b
Merge branch 'master' of https://github.com/kufu/smarthr-ui into chor…
AtsushiM Feb 13, 2025
fba01e2
chore: classNameの生成を調整
AtsushiM Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: fix ci
  • Loading branch information
@AtsushiM
AtsushiM committed Feb 7, 2025
commit 5638eab567e432baf19bd7b35e88535ce9ec48b0
4 changes: 2 additions & 2 deletions packages/smarthr-ui/src/components/TabBar/TabBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ export const TabBar: FC<Props & ElementProps> = ({
}, [bordered, className])

return (
<Reel {...props} role="tablist" className={className.wrapper}>
<div className={className.inner}>{children}</div>
<Reel {...props} role="tablist" className={classNames.wrapper}>
<div className={classNames.inner}>{children}</div>
</Reel>
)
}
2 changes: 1 addition & 1 deletion packages/smarthr-ui/src/components/TabBar/TabItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ const TabButton: FC<Props & ElementProps> = ({
className={classNames.wrapper}
onClick={actualOnClick}
>
<TabLabel className={classNames.label}>TabLabel</TabLabel>
<TabLabel className={classNames.label}>{children}</TabLabel>
<TabButtonSuffix className={classNames.suffixWrapper}>{suffix}</TabButtonSuffix>
</UnstyledButton>
)
Expand Down