chore: SegmentedControl, Radio系、ResponseMessageコンポーネントの内部処理を整理する #5385
+52
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
AtsushiM
commented
Feb 14, 2025
Comment on lines
-36
to
-46
| variants: { | ||
| disabled: { | ||
| true: { | ||
| label: 'shr-cursor-[revert] shr-text-disabled', | ||
| }, | ||
| false: { | ||
| label: 'shr-cursor-pointer', | ||
| box: 'peer-hover:shr-shadow-input-hover', | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
disabledは頻繁に変更される可能性があるため、variantsではなく、元々styleに可変するものとして記述するようにしました
AtsushiM
commented
Feb 14, 2025
| document.addEventListener('keydown', handleKeyDown) | ||
|
|
||
| return () => { | ||
| document.removeEventListener('keydown', handleKeyDown) | ||
| } | ||
| }, [handleKeyDown]) | ||
| }, [isFocused]) |
There was a problem hiding this comment.
handleKeydownはuseEffec中でしか利用されていないため、統合しました
AtsushiM
commented
Feb 14, 2025
|
|
||
| const excludesSelected = useMemo( | ||
| () => !value || options.every((option) => option.value !== value), | ||
| [options, value], | ||
| [value, options], |
There was a problem hiding this comment.
正しくmemo化されていれば、valueのほうが頻繁に変更されるため、依存関係チェックの優先度を入れ替えています
AtsushiM
requested review from
moshisora and
yuzuru-akiyama
and removed request for
a team
AtsushiM
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法