Skip to content

Commit

Permalink
Simplify libxmlrpc bundling and building
Browse files Browse the repository at this point in the history
The xmlrpc library is a forked, modified and bundled into the PHP source
code. Instead of having a separate *nix build system files in the xmlrpc
library this patch removes unneeded build checks.

- AC_PROG_CC is not needed to be called by the extension itself since it
  is already part of the main configure.ac and the phpize's
  configure.ac.
- UNDEF_THREADS_HACK is not used in the current codebase.
- Symbols defined by XMLRPC_HEADER_CHECKS are not used in the current
  code.
- Symbols defined by XMLRPC_FUNCTION_CHECKS are not used in the current
  code.
- AC_PROG_RANLIB is already done by the TSRM's files and isn't needed
  for the xmlrpc extension to work.
- AC_PROG_LN_S is already done by the PHP main configure.ac and also
  isn't needed by the xmlrpc extension to be built.
  • Loading branch information
petk committed Apr 23, 2019
1 parent 3cfbbf2 commit 96a9fb2
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 28 deletions.
6 changes: 0 additions & 6 deletions ext/xmlrpc/config.m4
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
dnl config.m4 for extension xmlrpc

sinclude(ext/xmlrpc/libxmlrpc/acinclude.m4)
sinclude(ext/xmlrpc/libxmlrpc/xmlrpc.m4)
sinclude(libxmlrpc/acinclude.m4)
sinclude(libxmlrpc/xmlrpc.m4)

PHP_ARG_WITH([xmlrpc],
[for XMLRPC-EPI support],
[AS_HELP_STRING([[--with-xmlrpc[=DIR]]],
Expand Down Expand Up @@ -80,7 +75,6 @@ if test "$PHP_XMLRPC" != "no"; then
fi

if test "$PHP_XMLRPC" = "yes"; then
XMLRPC_CHECKS
PHP_NEW_EXTENSION(xmlrpc,xmlrpc-epi-php.c libxmlrpc/base64.c \
libxmlrpc/simplestring.c libxmlrpc/xml_to_dandarpc.c \
libxmlrpc/xmlrpc_introspection.c libxmlrpc/encodings.c \
Expand Down
11 changes: 0 additions & 11 deletions ext/xmlrpc/libxmlrpc/acinclude.m4

This file was deleted.

11 changes: 0 additions & 11 deletions ext/xmlrpc/libxmlrpc/xmlrpc.m4

This file was deleted.

0 comments on commit 96a9fb2

Please sign in to comment.