Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kuma-cp): avoid concurrent access on resource meta (backport of #11997) #12025

Closed
wants to merge 1 commit into from
Closed

fix(kuma-cp): avoid concurrent access on resource meta (backport of #11997) #12025

wants to merge 1 commit into from

Conversation

kumahq[bot]
Copy link
Contributor

@kumahq kumahq bot commented Nov 12, 2024

Automatic cherry-pick of #11997 for branch release-2.5

Generated by action

cherry-picked commit c3d7187
⚠️ ⚠️ ⚠️ Conflicts happened when cherry-picking! ⚠️ ⚠️ ⚠️

On branch release-2.5
Your branch is up to date with 'origin/release-2.5'.

You are currently cherry-picking commit c3d7187c7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   pkg/kds/util/meta.go
	both modified:   pkg/kds/util/resource.go
	both modified:   pkg/plugins/resources/memory/store.go
	both modified:   pkg/plugins/resources/remote/store.go
	both modified:   pkg/plugins/secrets/k8s/store.go

no changes added to commit (use "git add" and/or "git commit -a")

@lahabana @michaelbeaumont @kumahq
fix(kuma-cp): avoid concurrent access on resource meta (#11997)
82d25dc 
There were some places where labels on meta weren't not cloned when
duplicating the meta. Walked the code for odd usages of `GetLabels()`.

See also #11886

Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
Co-authored-by: Mike Beaumont <[email protected]>
@kumahq kumahq bot requested a review from a team as a code owner November 12, 2024 11:39
@kumahq kumahq bot requested review from michaelbeaumont and Icarus9913 and removed request for a team November 12, 2024 11:39
@bartsmykla bartsmykla deleted the chore/backport-release-2.5-11997 branch December 11, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont michaelbeaumont is a code owner automatically assigned from kumahq/kuma-maintainers

@Icarus9913 Icarus9913 Awaiting requested review from Icarus9913 Icarus9913 is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
conflict release-2.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelbeaumont @lahabana