Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): squash helm tests (backport of #11901) #12310

Merged
merged 2 commits into from
Dec 17, 2024
Merged

test(e2e): squash helm tests (backport of #11901) #12310

merged 2 commits into from
Dec 17, 2024

Conversation

kumahq[bot]
Copy link
Contributor

@kumahq kumahq bot commented Dec 17, 2024

Automatic cherry-pick of #11901 for branch release-2.6

Generated by action

cherry-picked commit a649d8e
⚠️ ⚠️ ⚠️ Conflicts happened when cherry-picking! ⚠️ ⚠️ ⚠️

On branch release-2.6
Your branch is up to date with 'origin/release-2.6'.

You are currently cherry-picking commit a649d8ebd.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   test/e2e/bootstrap/corefile_template.go
	deleted:    test/e2e/helm/kuma_helm_deploy_multi_apps.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test/e2e/helm/e2e_suite_test.go

@jakubdyszkiewicz @kumahq
test(e2e): squash helm tests (#11901)
b1833c0 
Speed up CI

test/e2e/helm/kuma_helm_deploy_multi_apps.go was testing
1) HELM standalone deployment with CNI
2) Autoscaling of the CP (by checking minimum replicas)

1) Is tested in multiple places including
test/e2e/bootstrap/corefile_template.go
I just added 2) to existing test to save time

---------

Signed-off-by: Jakub Dyszkiewicz <[email protected]>
@kumahq kumahq bot requested a review from a team as a code owner December 17, 2024 15:11
@kumahq kumahq bot requested review from jakubdyszkiewicz and Automaat and removed request for a team December 17, 2024 15:11
@lukidzi
resolve
b4e00be 
Signed-off-by: Lukasz Dziedziak <[email protected]>
@lukidzi lukidzi removed the conflict label Dec 17, 2024
@lukidzi lukidzi merged commit d42c5d7 into release-2.6 Dec 17, 2024
12 checks passed
@lukidzi lukidzi deleted the chore/backport-release-2.6-11901 branch December 17, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi approved these changes

@jakubdyszkiewicz jakubdyszkiewicz Awaiting requested review from jakubdyszkiewicz jakubdyszkiewicz is a code owner automatically assigned from kumahq/kuma-maintainers

@Automaat Automaat Awaiting requested review from Automaat Automaat is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
release-2.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukidzi @jakubdyszkiewicz