Phase1.1 kumc(#6159) #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Maren and Dan |
dckc
reviewed
May 20, 2020
| alter table COVID_MED_PATHS add med_class varchar(50); | ||
| insert into COVID_MED_PATHS | ||
| select distinct 'Expand', d.concept_cd, m.med_class | ||
| from COVID_MED_MAP m | ||
| inner join concept_dimension c | ||
| inner join nightherondata.concept_dimension c |
There was a problem hiding this comment.
hard-coding schema names seems awkward. I wonder if I managed to avoid that before. I guess it doesn't hurt that much. But I wonder if synonyms would be better.
dckc
reviewed
May 21, 2020
| --union select '2703-7','third-code',1,'mmHg','PaO2' | ||
| -- TODO: Commented out | ||
| union | ||
| select '3255-7','3093',1,'mg/dL','Fibrinogen' from dual |
There was a problem hiding this comment.
Did you decide that syncing with the ACT ontology was too much trouble? We need to be able to explain to Russ why we're not doing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.