SAK-34030 Only have a single setter for RSF (sakaiproject#5428)

When binding parameters from a request to a bean RSF isn’t predictable in which setter will get used, this results in the binding failing 50% of the time. By renaming one of the methods we force RSF to use the one we want all the time.
kusmayady · Mar 23, 2018 · 28b7a9c · 28b7a9c
1 parent d2fc729
commit 28b7a9c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/mailsender/api/src/java/org/sakaiproject/mailsender/model/EmailEntry.java b/mailsender/api/src/java/org/sakaiproject/mailsender/model/EmailEntry.java
@@ -127,7 +127,8 @@ public ConfigEntry getConfig()
 		return config;
 	}
 
-	public void setOtherRecipients(List<String> otherRecipients)
+	// RSF Has a problem with overloaded setters so we force it to use the String one.
+	public void setOtherRecipientsList(List<String> otherRecipients)
 	{
 		this.otherRecipients = otherRecipients;
 	}

diff --git a/mailsender/api/src/test/org/sakaiproject/mailsender/model/EmailEntryTest.java b/mailsender/api/src/test/org/sakaiproject/mailsender/model/EmailEntryTest.java
@@ -132,7 +132,7 @@ public void setOtherRecipientsList() {
 		otherRecipients.add("[email protected]");
 		otherRecipients.add("[email protected]");
 
-		entry.setOtherRecipients(otherRecipients);
+		entry.setOtherRecipientsList(otherRecipients);
 		assertFalse(entry.getOtherRecipients().isEmpty());
 		assertEquals(3, entry.getOtherRecipients().size());
 		assertEquals("[email protected]", entry.getOtherRecipients().get(0));