SAK-43321 Moved showPhoto check to sakai-grader.js (sakaiproject#8014)

https://jira.sakaiproject.org/browse/SAK-43321
(cherry picked from commit 0a7aa42)

webcomponents/tool/src/main/frontend/js/grader/sakai-grader.js

@@ -152,7 +152,7 @@ class SakaiGrader extends gradableDataMixin(SakaiElement) {
           <select aria-label="${this.i18n["student_selector_label"]}" @change=${this.studentSelected}>
             ${this.submissions.map(s => html`<option value="${s.id}" .selected=${this.submission.id === s.id}>${s.groupId ? s.groupTitle : s.firstSubmitterName}</option>`)}
           </select>
-          ${this.submission.showPhoto ? html`
+          ${this.showPhoto() ? html`
             <span class="profile-image">
               <img src="/direct/profile/${this.submission.firstSubmitterId}/image/official?siteId=${portal.siteId}" alt="${this.submission.firstSubmitterName}${this.i18n["profile_image"]}"/>
             </span>
@@ -196,7 +196,7 @@ class SakaiGrader extends gradableDataMixin(SakaiElement) {
       <div class="grader ${this.graderOnLeft ? "on-left" : ""}">
         <div class="submitted-block">
           <div style="display: flex;">
-            ${this.submission.showPhoto ? html`
+            ${this.showPhoto() ? html`
               <div class="profile-image" style="flex: 1;">
                 <img src="/direct/profile/${this.submission.firstSubmitterId}/image/official?siteId=${portal.siteId}" alt="${this.submission.firstSubmitterName}${this.i18n["profile_image"]}" />
               </div>
@@ -381,6 +381,10 @@ class SakaiGrader extends gradableDataMixin(SakaiElement) {
     `;
   }
 
+  showPhoto() {
+    return this.showOfficialPhoto && !this.gradable.anonymousGrading && this.submission.firstSubmitterId && !this.submission.groupId;
+  }
+
   fileNameFromRef(ref) { return ref.substring(ref.lastIndexOf("\/") + 1); }
 
   toggleRubric(e) {

webcomponents/tool/src/main/frontend/js/grader/submission.js

@@ -49,8 +49,6 @@ export class Submission {
       this.feedbackComment = init.feedbackComment || "";
 
       this.allowResubmitNumber = this.properties["allow_resubmit_number"];
-
-      this.showPhoto = this.showOfficalPhoto && !this.anonymousGrading && this.submission.firstSubmitterId && !this.submission.groupId;
     } else {
       this.id = "dummy";
     }