Skip to content

Commit

Permalink
[PATCH] Generic ioremap_page_range: flush_cache_vmap
Browse files Browse the repository at this point in the history
The existing implementation of ioremap_page_range(), which was taken
from i386, does this:

	flush_cache_all();
	/* modify page tables */
	flush_tlb_all();

I think this is a bit defensive, so this patch changes the generic
implementation to do:

	/* modify page tables */
	flush_cache_vmap(start, end);

instead, which is similar to what vmalloc() does. This should still
be correct because we never modify existing PTEs. According to
James Bottomley:

The problem the flush_tlb_all() is trying to solve is to avoid stale tlb
entries in the ioremap area.  We're just being conservative by flushing
on both map and unmap.  Technically what vmalloc/vfree does (only flush
the tlb on unmap) is just fine because it means that the only tlb
entries in the remap area must belong to in-use mappings.

Signed-off-by: Haavard Skinnemoen <[email protected]>
Cc: Richard Henderson <[email protected]>
Cc: Ivan Kokshaysky <[email protected]>
Cc: Russell King <[email protected]>
Cc: Mikael Starvik <[email protected]>
Cc: Andi Kleen <[email protected]>
Cc: <[email protected]>
Cc: Ralf Baechle <[email protected]>
Cc: Kyle McMartin <[email protected]>
Cc: Martin Schwidefsky <[email protected]>
Cc: Paul Mundt <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Haavard Skinnemoen authored and Linus Torvalds committed Oct 1, 2006
1 parent 74588d8 commit db71daa
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions lib/ioremap.c
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,6 @@ int ioremap_page_range(unsigned long addr,

BUG_ON(addr >= end);

flush_cache_all();

start = addr;
phys_addr -= addr;
pgd = pgd_offset_k(addr);
Expand All @@ -88,7 +86,7 @@ int ioremap_page_range(unsigned long addr,
break;
} while (pgd++, addr = next, addr != end);

flush_tlb_all();
flush_cache_vmap(start, end);

return err;
}

0 comments on commit db71daa

Please sign in to comment.