Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move morsel dispatcher out of frontier pair #4681

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Jan 6, 2025

Description

This PR moves morsel dispatcher out of frontier pair and into FrontierTask so that the design is consistent for Vertex/Edge Compute.

Fixes # (issue)

Contributor agreement

Copy link

github-actions bot commented Jan 6, 2025

Benchmark Result

Master commit hash: 5e63cf2574ffe76c1a7fb2ca625e921acd932eaf
Branch commit hash: 37cf35ba35f05f580291b850108676a7c11efe5c

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 665.73 668.16 -2.44 (-0.36%)
aggregation q28 11111.31 13616.93 -2505.62 (-18.40%)
filter q14 137.70 141.40 -3.70 (-2.62%)
filter q15 140.47 143.93 -3.46 (-2.40%)
filter q16 318.50 322.81 -4.31 (-1.34%)
filter q17 465.56 466.09 -0.53 (-0.11%)
filter q18 1963.31 1971.82 -8.51 (-0.43%)
filter zonemap-node 99.33 100.80 -1.46 (-1.45%)
filter zonemap-node-lhs-cast 99.31 99.13 0.18 (0.18%)
filter zonemap-node-null 94.87 96.21 -1.34 (-1.39%)
filter zonemap-rel 5757.64 5796.83 -39.18 (-0.68%)
fixed_size_expr_evaluator q07 599.58 591.40 8.18 (1.38%)
fixed_size_expr_evaluator q08 833.10 827.38 5.73 (0.69%)
fixed_size_expr_evaluator q09 816.94 827.49 -10.55 (-1.27%)
fixed_size_expr_evaluator q10 252.89 251.28 1.60 (0.64%)
fixed_size_expr_evaluator q11 246.26 243.74 2.52 (1.03%)
fixed_size_expr_evaluator q12 246.79 239.68 7.11 (2.97%)
fixed_size_expr_evaluator q13 1493.60 1477.34 16.26 (1.10%)
fixed_size_seq_scan q23 133.05 126.68 6.37 (5.03%)
join q29 602.56 637.04 -34.49 (-5.41%)
join q30 10363.60 10193.64 169.96 (1.67%)
join q31 6.07 5.28 0.79 (14.91%)
join SelectiveTwoHopJoin 55.32 51.95 3.37 (6.50%)
ldbc_snb_ic q35 2572.07 2583.52 -11.45 (-0.44%)
ldbc_snb_ic q36 484.89 491.09 -6.20 (-1.26%)
ldbc_snb_is q32 7.09 7.07 0.02 (0.33%)
ldbc_snb_is q33 11.73 15.05 -3.32 (-22.06%)
ldbc_snb_is q34 1.27 1.24 0.03 (2.15%)
multi-rel multi-rel-large-scan 1359.33 1350.58 8.75 (0.65%)
multi-rel multi-rel-lookup 9.49 30.23 -20.74 (-68.62%)
multi-rel multi-rel-small-scan 87.63 94.37 -6.74 (-7.14%)
order_by q25 138.33 146.37 -8.04 (-5.50%)
order_by q26 469.75 469.53 0.22 (0.05%)
order_by q27 1484.81 1490.73 -5.92 (-0.40%)
recursive_join recursive-join-bidirection 303.80 301.90 1.90 (0.63%)
recursive_join recursive-join-dense 7481.60 7460.79 20.82 (0.28%)
recursive_join recursive-join-path 23987.56 24104.58 -117.01 (-0.49%)
recursive_join recursive-join-sparse 1074.66 1062.94 11.71 (1.10%)
recursive_join recursive-join-trail 7408.06 7392.65 15.41 (0.21%)
scan_after_filter q01 181.17 182.92 -1.75 (-0.96%)
scan_after_filter q02 170.72 168.99 1.73 (1.02%)
shortest_path_ldbc100 q37 89.51 94.09 -4.58 (-4.87%)
shortest_path_ldbc100 q38 296.18 372.08 -75.90 (-20.40%)
shortest_path_ldbc100 q39 60.87 60.94 -0.07 (-0.12%)
shortest_path_ldbc100 q40 382.34 397.34 -15.00 (-3.77%)
var_size_expr_evaluator q03 2122.54 2100.46 22.08 (1.05%)
var_size_expr_evaluator q04 2262.79 2297.11 -34.32 (-1.49%)
var_size_expr_evaluator q05 2690.51 2792.49 -101.98 (-3.65%)
var_size_expr_evaluator q06 1348.53 1353.17 -4.64 (-0.34%)
var_size_seq_scan q19 1457.15 1464.29 -7.15 (-0.49%)
var_size_seq_scan q20 2659.23 2727.51 -68.27 (-2.50%)
var_size_seq_scan q21 2297.26 2311.86 -14.60 (-0.63%)
var_size_seq_scan q22 128.26 131.62 -3.36 (-2.56%)

@andyfengHKU andyfengHKU merged commit 0c6a394 into master Jan 6, 2025
@andyfengHKU andyfengHKU deleted the refactor-frontier-task-morsel branch January 6, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants