Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macos extension test #4683

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Fix macos extension test #4683

merged 1 commit into from
Jan 7, 2025

Conversation

royi-luo
Copy link
Collaborator

@royi-luo royi-luo commented Jan 6, 2025 •
edited
Loading

Description

Add non-inlined virtual destructor to SimpleTableFuncSharedState to ensure that dynamic_cast to this class works when called from extensions.

See android/ndk#533 (comment) for more details.

Contributor agreement

@royi-luo royi-luo self-assigned this Jan 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

Benchmark Result

Master commit hash: 606eef8e2884694e3fa767045e5685b01daa62f0
Branch commit hash: a0a9968e43534c8ac9685b202af9c585a7d1d33a

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 652.99 662.73 -9.74 (-1.47%)
aggregation q28 11268.29 12127.88 -859.59 (-7.09%)
filter q14 134.85 131.13 3.72 (2.83%)
filter q15 132.07 126.91 5.16 (4.06%)
filter q16 311.32 311.89 -0.56 (-0.18%)
filter q17 456.91 455.26 1.65 (0.36%)
filter q18 1932.75 1907.55 25.20 (1.32%)
filter zonemap-node 97.94 89.66 8.29 (9.24%)
filter zonemap-node-lhs-cast 99.27 89.98 9.29 (10.33%)
filter zonemap-node-null 94.78 85.99 8.79 (10.22%)
filter zonemap-rel 5705.13 5492.81 212.32 (3.87%)
fixed_size_expr_evaluator q07 589.20 570.44 18.76 (3.29%)
fixed_size_expr_evaluator q08 821.04 799.48 21.56 (2.70%)
fixed_size_expr_evaluator q09 821.29 801.30 19.99 (2.49%)
fixed_size_expr_evaluator q10 255.11 236.33 18.77 (7.94%)
fixed_size_expr_evaluator q11 247.16 228.83 18.33 (8.01%)
fixed_size_expr_evaluator q12 244.47 225.84 18.63 (8.25%)
fixed_size_expr_evaluator q13 1468.61 1458.77 9.84 (0.67%)
fixed_size_seq_scan q23 128.41 113.50 14.90 (13.13%)
join q29 641.52 616.17 25.35 (4.11%)
join q30 10745.79 10279.23 466.57 (4.54%)
join q31 7.13 4.04 3.09 (76.53%)
join SelectiveTwoHopJoin 57.02 45.94 11.08 (24.11%)
ldbc_snb_ic q35 2553.19 2635.27 -82.08 (-3.11%)
ldbc_snb_ic q36 468.07 445.44 22.63 (5.08%)
ldbc_snb_is q32 6.42 5.54 0.88 (15.92%)
ldbc_snb_is q33 15.75 12.56 3.19 (25.43%)
ldbc_snb_is q34 1.29 0.85 0.44 (51.94%)
multi-rel multi-rel-large-scan 1371.76 1306.46 65.29 (5.00%)
multi-rel multi-rel-lookup 27.81 28.77 -0.96 (-3.35%)
multi-rel multi-rel-small-scan 68.47 81.08 -12.60 (-15.54%)
order_by q25 138.16 130.57 7.60 (5.82%)
order_by q26 461.94 459.94 2.00 (0.43%)
order_by q27 1460.55 1459.41 1.14 (0.08%)
recursive_join recursive-join-bidirection 290.81 272.92 17.90 (6.56%)
recursive_join recursive-join-dense 7360.24 7364.98 -4.74 (-0.06%)
recursive_join recursive-join-path 24426.98 23990.40 436.58 (1.82%)
recursive_join recursive-join-sparse 1063.37 1079.47 -16.10 (-1.49%)
recursive_join recursive-join-trail 7281.99 7297.36 -15.37 (-0.21%)
scan_after_filter q01 177.86 170.64 7.22 (4.23%)
scan_after_filter q02 165.83 157.36 8.47 (5.38%)
shortest_path_ldbc100 q37 90.55 82.64 7.91 (9.57%)
shortest_path_ldbc100 q38 354.20 369.53 -15.33 (-4.15%)
shortest_path_ldbc100 q39 66.97 62.24 4.73 (7.60%)
shortest_path_ldbc100 q40 443.34 461.72 -18.39 (-3.98%)
var_size_expr_evaluator q03 2080.32 2086.20 -5.88 (-0.28%)
var_size_expr_evaluator q04 2230.10 2170.41 59.69 (2.75%)
var_size_expr_evaluator q05 2627.27 2574.80 52.48 (2.04%)
var_size_expr_evaluator q06 1334.15 1322.89 11.27 (0.85%)
var_size_seq_scan q19 1458.32 1446.66 11.66 (0.81%)
var_size_seq_scan q20 2647.21 2358.30 288.91 (12.25%)
var_size_seq_scan q21 2293.26 2272.10 21.16 (0.93%)
var_size_seq_scan q22 129.43 124.85 4.59 (3.67%)

@royi-luo royi-luo force-pushed the royi/fix-macos-extension-test branch 2 times, most recently from 6c38936 to f39b344 Compare January 6, 2025 17:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

Benchmark Result

Master commit hash: 606eef8e2884694e3fa767045e5685b01daa62f0
Branch commit hash: 4c1a95f142116b705217773229bc2a53e5a1cfd7

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 656.42 662.73 -6.31 (-0.95%)
aggregation q28 11524.97 12127.88 -602.91 (-4.97%)
filter q14 134.84 131.13 3.71 (2.83%)
filter q15 138.68 126.91 11.77 (9.27%)
filter q16 312.93 311.89 1.05 (0.34%)
filter q17 460.42 455.26 5.17 (1.13%)
filter q18 1903.15 1907.55 -4.40 (-0.23%)
filter zonemap-node 97.34 89.66 7.69 (8.57%)
filter zonemap-node-lhs-cast 97.65 89.98 7.67 (8.52%)
filter zonemap-node-null 93.61 85.99 7.62 (8.86%)
filter zonemap-rel 5697.68 5492.81 204.87 (3.73%)
fixed_size_expr_evaluator q07 951.60 570.44 381.16 (66.82%)
fixed_size_expr_evaluator q08 823.90 799.48 24.41 (3.05%)
fixed_size_expr_evaluator q09 819.44 801.30 18.15 (2.26%)
fixed_size_expr_evaluator q10 252.81 236.33 16.48 (6.97%)
fixed_size_expr_evaluator q11 245.70 228.83 16.87 (7.37%)
fixed_size_expr_evaluator q12 242.14 225.84 16.30 (7.22%)
fixed_size_expr_evaluator q13 1464.88 1458.77 6.10 (0.42%)
fixed_size_seq_scan q23 124.25 113.50 10.74 (9.47%)
join q29 665.43 616.17 49.26 (7.99%)
join q30 10775.70 10279.23 496.48 (4.83%)
join q31 7.13 4.04 3.09 (76.54%)
join SelectiveTwoHopJoin 58.12 45.94 12.17 (26.49%)
ldbc_snb_ic q35 2539.05 2635.27 -96.22 (-3.65%)
ldbc_snb_ic q36 458.97 445.44 13.53 (3.04%)
ldbc_snb_is q32 2.82 5.54 -2.72 (-49.02%)
ldbc_snb_is q33 16.78 12.56 4.22 (33.56%)
ldbc_snb_is q34 1.37 0.85 0.51 (60.44%)
multi-rel multi-rel-large-scan 1374.46 1306.46 68.00 (5.20%)
multi-rel multi-rel-lookup 32.15 28.77 3.38 (11.75%)
multi-rel multi-rel-small-scan 72.33 81.08 -8.75 (-10.79%)
order_by q25 143.34 130.57 12.77 (9.78%)
order_by q26 470.86 459.94 10.92 (2.37%)
order_by q27 1483.81 1459.41 24.40 (1.67%)
recursive_join recursive-join-bidirection 287.77 272.92 14.85 (5.44%)
recursive_join recursive-join-dense 7377.69 7364.98 12.71 (0.17%)
recursive_join recursive-join-path 23673.94 23990.40 -316.46 (-1.32%)
recursive_join recursive-join-sparse 1061.83 1079.47 -17.64 (-1.63%)
recursive_join recursive-join-trail 7311.84 7297.36 14.49 (0.20%)
scan_after_filter q01 178.24 170.64 7.59 (4.45%)
scan_after_filter q02 166.81 157.36 9.45 (6.00%)
shortest_path_ldbc100 q37 87.98 82.64 5.35 (6.47%)
shortest_path_ldbc100 q38 352.66 369.53 -16.87 (-4.56%)
shortest_path_ldbc100 q39 62.89 62.24 0.65 (1.04%)
shortest_path_ldbc100 q40 397.50 461.72 -64.22 (-13.91%)
var_size_expr_evaluator q03 2071.89 2086.20 -14.31 (-0.69%)
var_size_expr_evaluator q04 2219.32 2170.41 48.91 (2.25%)
var_size_expr_evaluator q05 2622.06 2574.80 47.27 (1.84%)
var_size_expr_evaluator q06 1333.56 1322.89 10.67 (0.81%)
var_size_seq_scan q19 1455.10 1446.66 8.44 (0.58%)
var_size_seq_scan q20 2638.47 2358.30 280.18 (11.88%)
var_size_seq_scan q21 2275.55 2272.10 3.45 (0.15%)
var_size_seq_scan q22 129.02 124.85 4.18 (3.35%)

@codecov Codecov
Copy link

codecov bot commented Jan 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.22%. Comparing base (0c6a394) to head (3f8a81f).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4683      +/-   ##
==========================================
+ Coverage   86.13%   86.22%   +0.09%     
==========================================
  Files        1373     1369       -4     
  Lines       58295    58232      -63     
  Branches     7210     7205       -5     
==========================================
+ Hits        50212    50213       +1     
+ Misses       7919     7855      -64     
  Partials      164      164

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@royi-luo royi-luo force-pushed the royi/fix-macos-extension-test branch from f39b344 to 3f8a81f Compare January 7, 2025 17:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Benchmark Result

Master commit hash: 6caaad7a4bf510723ca5ebf5e656d8caab398ad8
Branch commit hash: 51f4edaeaf694ee66cdc5ec676e83c344d3fec85

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 649.11 658.31 -9.20 (-1.40%)
aggregation q28 11510.61 11491.80 18.81 (0.16%)
filter q14 128.37 128.08 0.29 (0.23%)
filter q15 128.89 126.51 2.38 (1.88%)
filter q16 309.60 300.93 8.66 (2.88%)
filter q17 447.41 444.82 2.59 (0.58%)
filter q18 1943.73 1974.23 -30.49 (-1.54%)
filter zonemap-node 89.09 89.16 -0.07 (-0.08%)
filter zonemap-node-lhs-cast 90.74 90.39 0.35 (0.39%)
filter zonemap-node-null 87.04 86.93 0.11 (0.13%)
filter zonemap-rel 5731.91 5719.87 12.04 (0.21%)
fixed_size_expr_evaluator q07 584.99 585.37 -0.37 (-0.06%)
fixed_size_expr_evaluator q08 817.49 821.78 -4.29 (-0.52%)
fixed_size_expr_evaluator q09 804.54 818.86 -14.32 (-1.75%)
fixed_size_expr_evaluator q10 237.74 242.37 -4.63 (-1.91%)
fixed_size_expr_evaluator q11 230.45 233.35 -2.90 (-1.24%)
fixed_size_expr_evaluator q12 230.96 229.93 1.03 (0.45%)
fixed_size_expr_evaluator q13 1459.59 1481.55 -21.96 (-1.48%)
fixed_size_seq_scan q23 112.44 113.01 -0.57 (-0.50%)
join q29 605.84 580.58 25.26 (4.35%)
join q30 10486.88 10439.46 47.42 (0.45%)
join q31 6.88 6.22 0.66 (10.58%)
join SelectiveTwoHopJoin 53.30 52.59 0.72 (1.36%)
ldbc_snb_ic q35 2567.38 2599.58 -32.20 (-1.24%)
ldbc_snb_ic q36 499.24 481.40 17.84 (3.71%)
ldbc_snb_is q32 8.27 7.30 0.97 (13.29%)
ldbc_snb_is q33 15.59 14.42 1.17 (8.13%)
ldbc_snb_is q34 1.23 1.29 -0.06 (-4.58%)
multi-rel multi-rel-large-scan 1475.10 1384.08 91.02 (6.58%)
multi-rel multi-rel-lookup 21.22 22.61 -1.39 (-6.16%)
multi-rel multi-rel-small-scan 95.10 60.34 34.76 (57.60%)
order_by q25 128.23 131.26 -3.03 (-2.31%)
order_by q26 447.87 460.69 -12.83 (-2.78%)
order_by q27 1480.98 1461.49 19.49 (1.33%)
recursive_join recursive-join-bidirection 310.88 261.00 49.87 (19.11%)
recursive_join recursive-join-dense 7447.06 7393.42 53.65 (0.73%)
recursive_join recursive-join-path 24030.93 24133.81 -102.88 (-0.43%)
recursive_join recursive-join-sparse 1058.07 1078.51 -20.45 (-1.90%)
recursive_join recursive-join-trail 7381.48 7353.37 28.11 (0.38%)
scan_after_filter q01 171.62 171.48 0.15 (0.09%)
scan_after_filter q02 155.54 155.79 -0.25 (-0.16%)
shortest_path_ldbc100 q37 82.93 79.84 3.09 (3.87%)
shortest_path_ldbc100 q38 355.58 360.44 -4.86 (-1.35%)
shortest_path_ldbc100 q39 67.50 65.18 2.31 (3.55%)
shortest_path_ldbc100 q40 431.76 447.15 -15.39 (-3.44%)
var_size_expr_evaluator q03 2068.22 2106.65 -38.43 (-1.82%)
var_size_expr_evaluator q04 2260.99 2237.52 23.47 (1.05%)
var_size_expr_evaluator q05 2604.45 2612.22 -7.77 (-0.30%)
var_size_expr_evaluator q06 1334.98 1341.52 -6.53 (-0.49%)
var_size_seq_scan q19 1448.89 1464.97 -16.09 (-1.10%)
var_size_seq_scan q20 2661.92 2704.43 -42.51 (-1.57%)
var_size_seq_scan q21 2265.02 2301.22 -36.20 (-1.57%)
var_size_seq_scan q22 126.05 125.58 0.47 (0.37%)

@royi-luo royi-luo requested a review from acquamarin January 7, 2025 18:45
@royi-luo royi-luo marked this pull request as ready for review January 7, 2025 18:58
@royi-luo royi-luo merged commit 080cbc0 into master Jan 7, 2025
25 checks passed
@royi-luo royi-luo deleted the royi/fix-macos-extension-test branch January 7, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acquamarin acquamarin acquamarin approved these changes

Assignees

@royi-luo royi-luo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@royi-luo @acquamarin