Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove property collector #4684

Merged
merged 2 commits into from
Jan 7, 2025
Merged

remove property collector #4684

merged 2 commits into from
Jan 7, 2025

Conversation

acquamarin
Copy link
Collaborator

This PR removes property collector which is used by fts before.

Copy link

github-actions bot commented Jan 6, 2025

Benchmark Result

Master commit hash: 0c6a394a32b9092e874b144516d9366a706e7d0b
Branch commit hash: c9461a03cfdf0b3e4f313d17de957a6aa63e12c6

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 655.65 666.67 -11.01 (-1.65%)
aggregation q28 11007.58 11065.46 -57.88 (-0.52%)
filter q14 127.80 135.68 -7.88 (-5.81%)
filter q15 128.11 137.85 -9.73 (-7.06%)
filter q16 302.23 311.89 -9.65 (-3.10%)
filter q17 445.04 458.85 -13.81 (-3.01%)
filter q18 1949.00 1951.28 -2.27 (-0.12%)
filter zonemap-node 89.56 97.66 -8.10 (-8.29%)
filter zonemap-node-lhs-cast 90.72 99.19 -8.47 (-8.54%)
filter zonemap-node-null 86.56 95.14 -8.58 (-9.01%)
filter zonemap-rel 5873.76 5771.06 102.69 (1.78%)
fixed_size_expr_evaluator q07 582.51 598.74 -16.23 (-2.71%)
fixed_size_expr_evaluator q08 814.70 820.53 -5.83 (-0.71%)
fixed_size_expr_evaluator q09 815.23 830.88 -15.65 (-1.88%)
fixed_size_expr_evaluator q10 241.58 257.47 -15.89 (-6.17%)
fixed_size_expr_evaluator q11 234.93 251.51 -16.58 (-6.59%)
fixed_size_expr_evaluator q12 229.88 247.01 -17.13 (-6.93%)
fixed_size_expr_evaluator q13 1487.07 1487.80 -0.72 (-0.05%)
fixed_size_seq_scan q23 121.41 134.46 -13.04 (-9.70%)
join q29 625.49 618.88 6.61 (1.07%)
join q30 10551.89 10218.46 333.43 (3.26%)
join q31 5.90 8.03 -2.13 (-26.53%)
join SelectiveTwoHopJoin 53.50 53.38 0.12 (0.22%)
ldbc_snb_ic q35 2565.22 2584.14 -18.92 (-0.73%)
ldbc_snb_ic q36 468.07 437.49 30.58 (6.99%)
ldbc_snb_is q32 5.51 7.15 -1.64 (-22.96%)
ldbc_snb_is q33 13.98 17.29 -3.31 (-19.13%)
ldbc_snb_is q34 1.23 1.32 -0.09 (-6.60%)
multi-rel multi-rel-large-scan 1410.43 1370.98 39.45 (2.88%)
multi-rel multi-rel-lookup 31.91 21.75 10.17 (46.75%)
multi-rel multi-rel-small-scan 95.16 93.15 2.01 (2.16%)
order_by q25 133.48 140.08 -6.61 (-4.72%)
order_by q26 457.42 466.46 -9.03 (-1.94%)
order_by q27 1478.13 1488.59 -10.46 (-0.70%)
recursive_join recursive-join-bidirection 274.70 290.18 -15.47 (-5.33%)
recursive_join recursive-join-dense 7464.56 7491.91 -27.35 (-0.37%)
recursive_join recursive-join-path 24313.35 24141.69 171.66 (0.71%)
recursive_join recursive-join-sparse 1073.30 1075.83 -2.53 (-0.23%)
recursive_join recursive-join-trail 7393.87 7408.65 -14.78 (-0.20%)
scan_after_filter q01 169.84 183.67 -13.83 (-7.53%)
scan_after_filter q02 160.53 169.27 -8.75 (-5.17%)
shortest_path_ldbc100 q37 88.50 84.03 4.47 (5.31%)
shortest_path_ldbc100 q38 356.76 373.50 -16.74 (-4.48%)
shortest_path_ldbc100 q39 66.63 59.41 7.22 (12.15%)
shortest_path_ldbc100 q40 416.56 415.67 0.89 (0.21%)
var_size_expr_evaluator q03 2057.24 2096.91 -39.66 (-1.89%)
var_size_expr_evaluator q04 2262.20 2260.65 1.55 (0.07%)
var_size_expr_evaluator q05 2634.08 2665.41 -31.33 (-1.18%)
var_size_expr_evaluator q06 1339.97 1349.59 -9.62 (-0.71%)
var_size_seq_scan q19 1460.64 1483.26 -22.62 (-1.52%)
var_size_seq_scan q20 2696.20 2691.53 4.67 (0.17%)
var_size_seq_scan q21 2301.04 2302.03 -0.99 (-0.04%)
var_size_seq_scan q22 126.21 129.64 -3.43 (-2.65%)

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.22%. Comparing base (0c6a394) to head (348edf9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4684      +/-   ##
==========================================
+ Coverage   86.13%   86.22%   +0.09%     
==========================================
  Files        1373     1369       -4     
  Lines       58295    58231      -64     
  Branches     7210     7206       -4     
==========================================
- Hits        50212    50211       -1     
+ Misses       7919     7856      -63     
  Partials      164      164              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 7, 2025

Benchmark Result

Master commit hash: 0c6a394a32b9092e874b144516d9366a706e7d0b
Branch commit hash: fc1881343c14074364e9d2b74b8a5969c5445268

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 644.84 666.67 -21.83 (-3.27%)
aggregation q28 11713.63 11065.46 648.16 (5.86%)
filter q14 132.23 135.68 -3.45 (-2.54%)
filter q15 130.02 137.85 -7.83 (-5.68%)
filter q16 308.28 311.89 -3.61 (-1.16%)
filter q17 452.01 458.85 -6.84 (-1.49%)
filter q18 1967.90 1951.28 16.62 (0.85%)
filter zonemap-node 93.47 97.66 -4.19 (-4.29%)
filter zonemap-node-lhs-cast 90.99 99.19 -8.20 (-8.26%)
filter zonemap-node-null 87.56 95.14 -7.58 (-7.97%)
filter zonemap-rel 5760.50 5771.06 -10.57 (-0.18%)
fixed_size_expr_evaluator q07 581.49 598.74 -17.26 (-2.88%)
fixed_size_expr_evaluator q08 820.09 820.53 -0.45 (-0.05%)
fixed_size_expr_evaluator q09 804.19 830.88 -26.69 (-3.21%)
fixed_size_expr_evaluator q10 241.88 257.47 -15.59 (-6.06%)
fixed_size_expr_evaluator q11 231.61 251.51 -19.90 (-7.91%)
fixed_size_expr_evaluator q12 231.15 247.01 -15.86 (-6.42%)
fixed_size_expr_evaluator q13 1485.81 1487.80 -1.99 (-0.13%)
fixed_size_seq_scan q23 113.12 134.46 -21.34 (-15.87%)
join q29 627.61 618.88 8.73 (1.41%)
join q30 10208.31 10218.46 -10.15 (-0.10%)
join q31 6.86 8.03 -1.17 (-14.61%)
join SelectiveTwoHopJoin 54.84 53.38 1.45 (2.72%)
ldbc_snb_ic q35 2594.88 2584.14 10.73 (0.42%)
ldbc_snb_ic q36 499.74 437.49 62.25 (14.23%)
ldbc_snb_is q32 4.34 7.15 -2.81 (-39.24%)
ldbc_snb_is q33 16.59 17.29 -0.70 (-4.03%)
ldbc_snb_is q34 1.31 1.32 -0.01 (-0.63%)
multi-rel multi-rel-large-scan 1373.86 1370.98 2.88 (0.21%)
multi-rel multi-rel-lookup 23.42 21.75 1.67 (7.70%)
multi-rel multi-rel-small-scan 67.20 93.15 -25.95 (-27.86%)
order_by q25 249.50 140.08 109.42 (78.11%)
order_by q26 775.14 466.46 308.69 (66.18%)
order_by q27 1514.16 1488.59 25.57 (1.72%)
recursive_join recursive-join-bidirection 298.44 290.18 8.26 (2.85%)
recursive_join recursive-join-dense 7467.76 7491.91 -24.16 (-0.32%)
recursive_join recursive-join-path 24156.31 24141.69 14.62 (0.06%)
recursive_join recursive-join-sparse 1056.32 1075.83 -19.51 (-1.81%)
recursive_join recursive-join-trail 7403.94 7408.65 -4.71 (-0.06%)
scan_after_filter q01 175.85 183.67 -7.82 (-4.26%)
scan_after_filter q02 158.64 169.27 -10.64 (-6.28%)
shortest_path_ldbc100 q37 91.10 84.03 7.07 (8.41%)
shortest_path_ldbc100 q38 367.15 373.50 -6.35 (-1.70%)
shortest_path_ldbc100 q39 69.60 59.41 10.19 (17.15%)
shortest_path_ldbc100 q40 408.87 415.67 -6.80 (-1.64%)
var_size_expr_evaluator q03 2128.16 2096.91 31.26 (1.49%)
var_size_expr_evaluator q04 2264.10 2260.65 3.45 (0.15%)
var_size_expr_evaluator q05 2620.10 2665.41 -45.30 (-1.70%)
var_size_expr_evaluator q06 1322.38 1349.59 -27.21 (-2.02%)
var_size_seq_scan q19 1443.80 1483.26 -39.46 (-2.66%)
var_size_seq_scan q20 2694.92 2691.53 3.38 (0.13%)
var_size_seq_scan q21 2303.48 2302.03 1.45 (0.06%)
var_size_seq_scan q22 127.56 129.64 -2.08 (-1.61%)

@acquamarin acquamarin merged commit 69bd461 into master Jan 7, 2025
24 of 25 checks passed
@acquamarin acquamarin deleted the remove-property-collector branch January 7, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants