Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Java docstring #4729

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Fix Java docstring #4729

merged 1 commit into from
Jan 17, 2025

Conversation

mewim
Copy link
Member

@mewim mewim commented Jan 17, 2025

Description

The format string in the docstring seems to cause docs generation and deployment failure. In this PR I remove it.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.31%. Comparing base (bb6d3ec) to head (27c2a4a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4729   +/-   ##
=======================================
  Coverage   86.31%   86.31%           
=======================================
  Files        1392     1392           
  Lines       59809    59809           
  Branches     7351     7351           
=======================================
+ Hits        51622    51623    +1     
+ Misses       8022     8020    -2     
- Partials      165      166    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark Result

Master commit hash: cba13a1d015a316278de80ce3d2169bb0a209a87
Branch commit hash: 4a3a92c410e7b9998d88d8bf7c99b8133cdc6416

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 648.47 631.26 17.21 (2.73%)
aggregation q28 11386.69 11004.81 381.89 (3.47%)
filter q14 135.73 118.13 17.60 (14.90%)
filter q15 137.92 121.44 16.47 (13.56%)
filter q16 312.77 292.25 20.52 (7.02%)
filter q17 454.83 442.49 12.35 (2.79%)
filter q18 1950.30 1904.21 46.08 (2.42%)
filter zonemap-node 97.89 81.07 16.81 (20.74%)
filter zonemap-node-lhs-cast 97.49 85.02 12.47 (14.67%)
filter zonemap-node-null 93.46 80.96 12.50 (15.44%)
filter zonemap-rel 5726.47 5730.01 -3.54 (-0.06%)
fixed_size_expr_evaluator q07 580.03 567.56 12.47 (2.20%)
fixed_size_expr_evaluator q08 809.00 792.57 16.43 (2.07%)
fixed_size_expr_evaluator q09 809.82 795.71 14.11 (1.77%)
fixed_size_expr_evaluator q10 244.27 228.62 15.65 (6.84%)
fixed_size_expr_evaluator q11 237.33 222.41 14.92 (6.71%)
fixed_size_expr_evaluator q12 234.77 218.55 16.22 (7.42%)
fixed_size_expr_evaluator q13 1461.70 1444.21 17.49 (1.21%)
fixed_size_seq_scan q23 119.31 102.79 16.51 (16.07%)
join q29 634.43 614.96 19.46 (3.16%)
join q30 10742.33 11225.88 -483.54 (-4.31%)
join q31 5.59 7.35 -1.76 (-23.96%)
join SelectiveTwoHopJoin 59.51 58.62 0.89 (1.52%)
ldbc_snb_ic q35 2600.36 2609.53 -9.18 (-0.35%)
ldbc_snb_ic q36 520.85 448.12 72.73 (16.23%)
ldbc_snb_is q32 6.39 6.13 0.26 (4.25%)
ldbc_snb_is q33 15.16 13.04 2.12 (16.28%)
ldbc_snb_is q34 1.38 1.41 -0.03 (-2.40%)
multi-rel multi-rel-large-scan 1797.65 1712.36 85.28 (4.98%)
multi-rel multi-rel-lookup 51.60 59.19 -7.58 (-12.81%)
multi-rel multi-rel-small-scan 1450.18 1572.66 -122.48 (-7.79%)
order_by q25 146.56 130.39 16.17 (12.40%)
order_by q26 461.25 461.20 0.05 (0.01%)
order_by q27 1467.63 1451.05 16.58 (1.14%)
recursive_join recursive-join-bidirection 304.30 307.47 -3.17 (-1.03%)
recursive_join recursive-join-dense 7339.31 7368.25 -28.94 (-0.39%)
recursive_join recursive-join-path 24134.88 23965.95 168.92 (0.70%)
recursive_join recursive-join-sparse 1062.60 1061.11 1.50 (0.14%)
recursive_join recursive-join-trail 7300.99 7323.78 -22.79 (-0.31%)
scan_after_filter q01 178.95 163.96 14.99 (9.14%)
scan_after_filter q02 166.44 149.14 17.30 (11.60%)
shortest_path_ldbc100 q37 98.83 89.09 9.74 (10.93%)
shortest_path_ldbc100 q38 347.49 371.90 -24.41 (-6.56%)
shortest_path_ldbc100 q39 59.91 60.94 -1.02 (-1.68%)
shortest_path_ldbc100 q40 436.36 436.11 0.25 (0.06%)
var_size_expr_evaluator q03 2091.37 2060.53 30.84 (1.50%)
var_size_expr_evaluator q04 2253.26 2198.73 54.52 (2.48%)
var_size_expr_evaluator q05 2634.48 2587.72 46.77 (1.81%)
var_size_expr_evaluator q06 1340.65 1335.39 5.27 (0.39%)
var_size_seq_scan q19 1459.17 1438.89 20.27 (1.41%)
var_size_seq_scan q20 2688.09 2724.76 -36.67 (-1.35%)
var_size_seq_scan q21 2293.34 2278.36 14.99 (0.66%)
var_size_seq_scan q22 128.72 124.04 4.68 (3.77%)

@ray6080 ray6080 merged commit 32b3ea4 into master Jan 17, 2025
25 checks passed
@ray6080 ray6080 deleted the mewim-patch-1 branch January 17, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants