-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix renaming property with indexes #4763
base: master
Are you sure you want to change the base?
Conversation
Benchmark ResultMaster commit hash:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the change can properly address issue #4761.
The property idx is not fixed, and will change when we drop columns from the table. I think the correct way to handle this is to assign a fixed property id to each Property, and you can use that to make sure the index will always refer to the correct property definition.
9e19723
to
b0b1f6d
Compare
This PR fixes renaming properties with indexes.
Closes #4762
Closes #4761