Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renaming property with indexes #4763

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

acquamarin
Copy link
Collaborator

This PR fixes renaming properties with indexes.

Closes #4762
Closes #4761

Copy link

Benchmark Result

Master commit hash: 1726860bb142291f6e267f4e32556807fcf6c81f
Branch commit hash: 071d38267b1b12ba28961250b277f9c1da9df27c

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 638.25 655.74 -17.48 (-2.67%)
aggregation q28 11696.99 11044.51 652.48 (5.91%)
filter q14 127.79 143.22 -15.43 (-10.77%)
filter q15 126.26 148.94 -22.68 (-15.23%)
filter q16 307.23 320.44 -13.21 (-4.12%)
filter q17 447.48 462.42 -14.94 (-3.23%)
filter q18 1901.65 1918.53 -16.88 (-0.88%)
filter zonemap-node 88.48 105.62 -17.14 (-16.23%)
filter zonemap-node-lhs-cast 90.76 105.51 -14.75 (-13.98%)
filter zonemap-node-null 85.98 101.85 -15.87 (-15.58%)
filter zonemap-rel 5664.23 5913.04 -248.82 (-4.21%)
fixed_size_expr_evaluator q07 572.83 589.16 -16.34 (-2.77%)
fixed_size_expr_evaluator q08 804.28 821.51 -17.24 (-2.10%)
fixed_size_expr_evaluator q09 800.12 818.78 -18.66 (-2.28%)
fixed_size_expr_evaluator q10 237.19 255.23 -18.04 (-7.07%)
fixed_size_expr_evaluator q11 229.62 247.63 -18.01 (-7.27%)
fixed_size_expr_evaluator q12 226.99 243.06 -16.08 (-6.61%)
fixed_size_expr_evaluator q13 1462.88 1468.88 -6.00 (-0.41%)
fixed_size_seq_scan q23 113.16 127.48 -14.32 (-11.23%)
join q29 649.41 610.22 39.19 (6.42%)
join q30 10056.50 10006.60 49.89 (0.50%)
join q31 5.38 5.00 0.38 (7.68%)
join SelectiveTwoHopJoin 53.77 54.66 -0.89 (-1.63%)
ldbc_snb_ic q35 2567.62 2620.95 -53.34 (-2.03%)
ldbc_snb_ic q36 486.42 476.79 9.63 (2.02%)
ldbc_snb_is q32 5.40 6.32 -0.92 (-14.55%)
ldbc_snb_is q33 14.11 10.93 3.18 (29.08%)
ldbc_snb_is q34 1.40 1.48 -0.08 (-5.42%)
multi-rel multi-rel-large-scan 1400.73 1380.65 20.08 (1.45%)
multi-rel multi-rel-lookup 8.83 39.72 -30.89 (-77.76%)
multi-rel multi-rel-small-scan 79.26 73.73 5.53 (7.51%)
order_by q25 134.08 145.93 -11.85 (-8.12%)
order_by q26 462.06 473.81 -11.75 (-2.48%)
order_by q27 1461.52 1468.97 -7.45 (-0.51%)
recursive_join recursive-join-bidirection 290.19 271.81 18.38 (6.76%)
recursive_join recursive-join-dense 7343.53 5960.45 1383.08 (23.20%)
recursive_join recursive-join-path 23616.19 23524.84 91.35 (0.39%)
recursive_join recursive-join-sparse 1052.39 1056.84 -4.45 (-0.42%)
recursive_join recursive-join-trail 7332.88 6152.73 1180.14 (19.18%)
scan_after_filter q01 170.82 187.30 -16.48 (-8.80%)
scan_after_filter q02 156.10 173.10 -17.00 (-9.82%)
shortest_path_ldbc100 q37 94.00 89.55 4.45 (4.97%)
shortest_path_ldbc100 q38 364.12 379.13 -15.01 (-3.96%)
shortest_path_ldbc100 q39 66.39 60.59 5.80 (9.58%)
shortest_path_ldbc100 q40 434.46 457.32 -22.86 (-5.00%)
var_size_expr_evaluator q03 2068.23 2097.65 -29.43 (-1.40%)
var_size_expr_evaluator q04 2300.25 2206.08 94.16 (4.27%)
var_size_expr_evaluator q05 2630.04 2643.59 -13.55 (-0.51%)
var_size_expr_evaluator q06 1328.01 1347.10 -19.09 (-1.42%)
var_size_seq_scan q19 1445.10 1476.01 -30.91 (-2.09%)
var_size_seq_scan q20 2621.95 2816.23 -194.28 (-6.90%)
var_size_seq_scan q21 2267.97 2338.25 -70.28 (-3.01%)
var_size_seq_scan q22 124.63 129.98 -5.35 (-4.12%)

@ray6080 ray6080 self-requested a review January 22, 2025 02:32
Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the change can properly address issue #4761.

The property idx is not fixed, and will change when we drop columns from the table. I think the correct way to handle this is to assign a fixed property id to each Property, and you can use that to make sure the index will always refer to the correct property definition.

extension/fts/test/test_files/fts_small.test Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants