change timestamp mask, fixes 1865 (tidyverse#1866)

kvpradap · May 31, 2016 · a143faf · a143faf
1 parent 9f1b19e
commit a143faf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/R/sql-escape.r b/R/sql-escape.r
@@ -122,7 +122,7 @@ escape.Date <- function(x, parens = NA, collapse = ", ", con = NULL) {
 
 #' @export
 escape.POSIXt <- function(x, parens = NA, collapse = ", ", con = NULL) {
-  x <- strftime(x, "%Y-%m-%d %H:%M:%S", tz = "UTC")
+  x <- strftime(x, "%Y-%m-%dT%H:%M:%OSZ", tz = "UTC")
   escape.character(x, parens = parens, collapse = collapse, con = con)
 }
 

diff --git a/tests/testthat/test-sql-escape.r b/tests/testthat/test-sql-escape.r
@@ -30,6 +30,6 @@ test_that("missing vaues become null", {
 
 test_that("times are converted to ISO 8601", {
   x <- ISOdatetime(2000, 1, 2, 3, 4, 5, tz = "US/Central")
-  expect_equal(escape(x), sql("'2000-01-02 09:04:05'"))
+  expect_equal(escape(x), sql("'2000-01-02T09:04:05Z'"))
 })