Skip to content

Commit

Permalink
time: ntp: simplify ntp_tick_adj calculations
Browse files Browse the repository at this point in the history
Impact: micro-optimization

Convert the (internal) ntp_tick_adj value we store from unscaled
units to scaled units. This is a constant that we never modify,
so scaling it up once during bootup is enough - we dont have to
do it for every adjustment step.

Signed-off-by: Ingo Molnar <[email protected]>
  • Loading branch information
Ingo Molnar committed Feb 25, 2009
1 parent 2b9d149 commit 069569e
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions kernel/time/ntp.c
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ static long time_reftime;

long time_adjust;

static long ntp_tick_adj;
/* constant (boot-param configurable) NTP tick adjustment (upscaled) */
static s64 ntp_tick_adj;

/*
* NTP methods:
Expand All @@ -89,7 +90,7 @@ static void ntp_update_frequency(void)
second_length = (u64)(tick_usec * NSEC_PER_USEC * USER_HZ)
<< NTP_SCALE_SHIFT;

second_length += (s64)ntp_tick_adj << NTP_SCALE_SHIFT;
second_length += ntp_tick_adj;
second_length += time_freq;

tick_nsec = div_u64(second_length, HZ) >> NTP_SCALE_SHIFT;
Expand Down Expand Up @@ -540,6 +541,8 @@ int do_adjtimex(struct timex *txc)
static int __init ntp_tick_adj_setup(char *str)
{
ntp_tick_adj = simple_strtol(str, NULL, 0);
ntp_tick_adj <<= NTP_SCALE_SHIFT;

return 1;
}

Expand Down

0 comments on commit 069569e

Please sign in to comment.