forked from torvalds/linux
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SCSI] megaraid_{mm,mbox}: a fix on "kernel unaligned access address"…
… issue There was an issue in the data structure defined by megaraid driver casuing "kernel unaligned access.." messages to be displayed during IOCTL on IA64 platform. The issue has been reported/fixed by Sakurai Hiroomi [[email protected]]. Signed-Off By: Seokmann Ju <[email protected]> Signed-off-by: James Bottomley <[email protected]>
- Loading branch information
Ju, Seokmann
authored and
James Bottomley
committed
Jul 28, 2006
1 parent
aa677bc
commit 0b4972d
Showing
4 changed files
with
62 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,6 +66,61 @@ Older Version : 2.20.4.8 (scsi module), 2.20.2.6 (cmm module) | |
Fix: MegaRAID F/W has fixed the problem and being process of release, | ||
soon. Meanwhile, driver will filter out the request. | ||
|
||
3. One of member in the data structure of the driver leads unaligne | ||
issue on 64-bit platform. | ||
Customer reporeted "kernel unaligned access addrss" issue when | ||
application communicates with MegaRAID HBA driver. | ||
Root Cause: in uioc_t structure, one of member had misaligned and it | ||
led system to display the error message. | ||
Fix: A patch submitted to community from following folk. | ||
|
||
> -----Original Message----- | ||
> From: [email protected] | ||
> [mailto:[email protected]] On Behalf Of Sakurai Hiroomi | ||
> Sent: Wednesday, July 12, 2006 4:20 AM | ||
> To: [email protected]; [email protected] | ||
> Subject: Re: Help: strange messages from kernel on IA64 platform | ||
> | ||
> Hi, | ||
> | ||
> I saw same message. | ||
> | ||
> When GAM(Global Array Manager) is started, The following | ||
> message output. | ||
> kernel: kernel unaligned access to 0xe0000001fe1080d4, | ||
> ip=0xa000000200053371 | ||
> | ||
> The uioc structure used by ioctl is defined by packed, | ||
> the allignment of each member are disturbed. | ||
> In a 64 bit structure, the allignment of member doesn't fit 64 bit | ||
> boundary. this causes this messages. | ||
> In a 32 bit structure, we don't see the message because the allinment | ||
> of member fit 32 bit boundary even if packed is specified. | ||
> | ||
> patch | ||
> I Add 32 bit dummy member to fit 64 bit boundary. I tested. | ||
> We confirmed this patch fix the problem by IA64 server. | ||
> | ||
> ************************************************************** | ||
> **************** | ||
> --- linux-2.6.9/drivers/scsi/megaraid/megaraid_ioctl.h.orig | ||
> 2006-04-03 17:13:03.000000000 +0900 | ||
> +++ linux-2.6.9/drivers/scsi/megaraid/megaraid_ioctl.h | ||
> 2006-04-03 17:14:09.000000000 +0900 | ||
> @@ -132,6 +132,10 @@ | ||
> /* Driver Data: */ | ||
> void __user * user_data; | ||
> uint32_t user_data_len; | ||
> + | ||
> + /* 64bit alignment */ | ||
> + uint32_t pad_0xBC; | ||
> + | ||
> mraid_passthru_t __user *user_pthru; | ||
> | ||
> mraid_passthru_t *pthru32; | ||
> ************************************************************** | ||
> **************** | ||
|
||
Release Date : Mon Apr 11 12:27:22 EST 2006 - Seokmann Ju <[email protected]> | ||
Current Version : 2.20.4.8 (scsi module), 2.20.2.6 (cmm module) | ||
Older Version : 2.20.4.7 (scsi module), 2.20.2.6 (cmm module) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters