Skip to content

Commit

Permalink
[PATCH] sky2: fix hotplug detect during poll
Browse files Browse the repository at this point in the history
If the poll routine detects no hardware available, it needs to dequeue
it self from the network poll list. Linus didn't understand NAPI.

Signed-off-by: Stephen Hemminger <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Stephen Hemminger authored and Linus Torvalds committed Jun 13, 2006
1 parent f05267e commit 26ec43f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/sky2.c
Original file line number Diff line number Diff line change
Expand Up @@ -2181,7 +2181,7 @@ static int sky2_poll(struct net_device *dev0, int *budget)
u32 status = sky2_read32(hw, B0_Y2_SP_EISR);

if (!~status)
return 0;
goto out;

if (status & Y2_IS_HW_ERR)
sky2_hw_intr(hw);
Expand Down Expand Up @@ -2219,7 +2219,7 @@ static int sky2_poll(struct net_device *dev0, int *budget)

if (sky2_more_work(hw))
return 1;

out:
netif_rx_complete(dev0);

sky2_read32(hw, B0_Y2_SP_LISR);
Expand Down

0 comments on commit 26ec43f

Please sign in to comment.