Skip to content

Commit

Permalink
powerpc/eeh: Output PHB diag-data
Browse files Browse the repository at this point in the history
When hitting frozen PE or fenced PHB, it's always indicative to
have dumped PHB diag-data for further analysis and diagnosis.
However, we never dump that for the cases. The patch intends to
dump PHB diag-data at the backend of eeh_ops::get_log() for PowerNV
platform.

Signed-off-by: Gavin Shan <[email protected]>
Signed-off-by: Benjamin Herrenschmidt <[email protected]>
  • Loading branch information
shangw authored and ozbenh committed Dec 5, 2013
1 parent 93aef2a commit 2c77e95
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions arch/powerpc/platforms/powernv/eeh-ioda.c
Original file line number Diff line number Diff line change
Expand Up @@ -588,11 +588,8 @@ static int ioda_eeh_get_log(struct eeh_pe *pe, int severity,
return -EIO;
}

/*
* FIXME: We probably need log the error in somewhere.
* Lets make it up in future.
*/
/* pr_info("%s", phb->diag.blob); */
/* The PHB diag-data is always indicative */
pnv_pci_dump_phb_diag_data(hose, phb->diag.blob);

spin_unlock_irqrestore(&phb->lock, flags);

Expand Down

0 comments on commit 2c77e95

Please sign in to comment.