Skip to content

Commit

Permalink
ext3: update ctime when changing the file's permission by setfacl
Browse files Browse the repository at this point in the history
ext3 didn't update the ctime of the file when its permission was changed.

Steps to reproduce:
 # touch aaa
 # stat -c %Z aaa
 1275289822
 # setfacl -m  'u::x,g::x,o::x' aaa
 # stat -c %Z aaa
 1275289822				<- unchanged

But, according to the spec of the ctime, ext3 must update it.

Signed-off-by: Miao Xie <[email protected]>
Signed-off-by: Jan Kara <[email protected]>
  • Loading branch information
Miao Xie authored and jankara committed Jun 24, 2010
1 parent 523825b commit 30e2bab
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions fs/ext3/acl.c
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ ext3_set_acl(handle_t *handle, struct inode *inode, int type,
return error;
else {
inode->i_mode = mode;
inode->i_ctime = CURRENT_TIME_SEC;
ext3_mark_inode_dirty(handle, inode);
if (error == 0)
acl = NULL;
Expand Down

0 comments on commit 30e2bab

Please sign in to comment.