Skip to content

Commit

Permalink
mfd: omap-usb-host: Fix improper mask use.
Browse files Browse the repository at this point in the history
single-ulpi-bypass is a flag used for older OMAP3 silicon.

The flag when set, can excite code that improperly uses the
OMAP_UHH_HOSTCONFIG_UPLI_BYPASS define to clear the corresponding bit.
Instead it clears all of the other bits disabling all of the ports in
the process.

Cc: [email protected]
Signed-off-by: Michael Welling <[email protected]>
Signed-off-by: Lee Jones <[email protected]>
  • Loading branch information
Michael Welling authored and Lee Jones committed Jul 29, 2014
1 parent 30a2af3 commit 46de8ff
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/mfd/omap-usb-host.c
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ static unsigned omap_usbhs_rev1_hostconfig(struct usbhs_hcd_omap *omap,

for (i = 0; i < omap->nports; i++) {
if (is_ehci_phy_mode(pdata->port_mode[i])) {
reg &= OMAP_UHH_HOSTCONFIG_ULPI_BYPASS;
reg &= ~OMAP_UHH_HOSTCONFIG_ULPI_BYPASS;
break;
}
}
Expand Down

0 comments on commit 46de8ff

Please sign in to comment.